Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Segment Replication] Handle failover in mixed cluster mode #9652

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ff65403 from #9536.

* pick oldest OS version replica to promote as primary

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* add test

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* refactor

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* refactor to avoid coupling

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

* add comments

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

---------

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
(cherry picked from commit ff65403)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 0dfcf49

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@tlfeng tlfeng added backport PRs or issues specific to backporting features or enhancments skip-changelog v2.10.0 labels Aug 31, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Poojita-Raj
Copy link
Contributor

2 gradle check runs - flaky: #9624
1 gradle check run - flaky: #9580

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #9652 (0dfcf49) into 2.x (21da767) will increase coverage by 0.01%.
Report is 5 commits behind head on 2.x.
The diff coverage is 84.00%.

@@             Coverage Diff              @@
##                2.x    #9652      +/-   ##
============================================
+ Coverage     70.88%   70.89%   +0.01%     
- Complexity    57730    57782      +52     
============================================
  Files          4770     4770              
  Lines        272705   272721      +16     
  Branches      40147    40148       +1     
============================================
+ Hits         193303   193343      +40     
+ Misses        62844    62822      -22     
+ Partials      16558    16556       -2     
Files Changed Coverage Δ
...main/java/org/opensearch/cluster/ClusterState.java 97.84% <ø> (-0.03%) ⬇️
...opensearch/action/get/TransportMultiGetAction.java 46.42% <50.00%> (+2.79%) ⬆️
.../org/opensearch/action/get/TransportGetAction.java 65.30% <83.33%> (+3.08%) ⬆️
...a/org/opensearch/cluster/routing/RoutingNodes.java 85.25% <83.33%> (-0.06%) ⬇️
...java/org/opensearch/cluster/metadata/Metadata.java 87.73% <100.00%> (-0.18%) ⬇️

... and 425 files with indirect coverage changes

@kotwanikunal kotwanikunal merged commit 0873b99 into 2.x Aug 31, 2023
20 of 45 checks passed
@github-actions github-actions bot deleted the backport/backport-9536-to-2.x branch August 31, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments skip-changelog v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants