Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Decouple replication lag from logic to fail stale replicas (#9507) #9705

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Sep 1, 2023

Manual backport of #9507

…h-project#9507)

* Decouple replication lag from replication timer logic used to fail stale replicas

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Added changelog entry

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Addressed comments

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Addressed comments 2

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Addressed comments

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Retry gradle

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* fix UT

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Addressed comments

Signed-off-by: Ankit Kala <ankikala@amazon.com>

* Retry Gradle

Signed-off-by: Ankit Kala <ankikala@amazon.com>

---------

Signed-off-by: Ankit Kala <ankikala@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Compatibility status:

Checks if related components are compatible with change bee6497

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #9705 (bee6497) into 2.x (9e41df4) will decrease coverage by 0.03%.
Report is 6 commits behind head on 2.x.
The diff coverage is 75.66%.

@@             Coverage Diff              @@
##                2.x    #9705      +/-   ##
============================================
- Coverage     70.86%   70.83%   -0.03%     
- Complexity    57786    57839      +53     
============================================
  Files          4776     4788      +12     
  Lines        273121   273359     +238     
  Branches      40198    40220      +22     
============================================
+ Hits         193537   193644     +107     
- Misses        63032    63168     +136     
+ Partials      16552    16547       -5     
Files Changed Coverage Δ
...java/org/opensearch/common/crypto/DataKeyPair.java 0.00% <0.00%> (ø)
...ain/java/org/opensearch/common/unit/TimeValue.java 87.50% <ø> (+1.25%) ⬆️
...ibs/core/src/main/java/org/opensearch/Version.java 82.45% <ø> (-1.32%) ⬇️
.../src/main/java/org/opensearch/core/ParseField.java 95.65% <ø> (ø)
...ava/org/opensearch/core/action/ActionListener.java 78.50% <0.00%> (-1.87%) ⬇️
...g/opensearch/core/common/bytes/BytesReference.java 88.57% <ø> (+14.28%) ⬆️
.../core/common/io/stream/NamedWriteableRegistry.java 100.00% <ø> (ø)
.../opensearch/core/common/io/stream/StreamInput.java 88.45% <ø> (-0.40%) ⬇️
...opensearch/core/common/io/stream/StreamOutput.java 94.88% <ø> (-0.81%) ⬇️
.../opensearch/core/common/settings/SecureString.java 78.78% <ø> (ø)
... and 57 more

... and 455 files with indirect coverage changes

@mch2 mch2 merged commit 7b92825 into opensearch-project:2.x Sep 2, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants