Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validation constraints for characters used in the Date Math #18

Merged
merged 2 commits into from
Jun 18, 2021

Conversation

adityaj1107
Copy link
Contributor

@adityaj1107 adityaj1107 commented Jun 16, 2021

Signed-off-by: Aditya Jindal aditjind@amazon.com

Description

This change removes the validation for characters which are used to define the index pattern to resolve the index date to a date.

Also updates the link to the documentation for the docs for Alerting Plugin.

Issues Resolved

opensearch-project/alerting#74
#17
opensearch-project/alerting#17

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Documentation is in progress.

After this change we will be able to define the indices:

Screen Shot 2021-06-16 at 3 45 36 PM

Current date is 2021.06.16
<my-{index}-{now/d{yyyy.MM.dd|+12:00}}> resolves to my-{index}-2021.06.17
<my-index-{now/d}> resolves to my-index-2021.06.16

@adityaj1107 adityaj1107 marked this pull request as draft June 16, 2021 22:50
Aditya Jindal added 2 commits June 16, 2021 15:56
…Indices

Signed-off-by: Aditya Jindal <aditjind@amazon.com>
Signed-off-by: Aditya Jindal <aditjind@amazon.com>
@adityaj1107 adityaj1107 self-assigned this Jun 17, 2021
@adityaj1107 adityaj1107 marked this pull request as ready for review June 17, 2021 00:34
@adityaj1107 adityaj1107 merged commit ae1c0e8 into main Jun 18, 2021
adityaj1107 pushed a commit that referenced this pull request Jun 19, 2021
Signed-off-by: Aditya Jindal <aditjind@amazon.com>

* Updating Dependencies of Lodash

Signed-off-by: Aditya Jindal <aditjind@amazon.com>
@adityaj1107 adityaj1107 added the bug Something isn't working label Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants