Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored the help text elements displayed when users access the destinations list page after destinations deprecation. #413

Merged
merged 7 commits into from
Jan 10, 2023

Conversation

AWSHurneyt
Copy link
Collaborator

@AWSHurneyt AWSHurneyt commented Dec 9, 2022

Description

Refactored the help text elements displayed when users access the destinations list page after destinations deprecation.

Issues Resolved

[List any issues this PR will resolve]

Known issues

  1. The full info page element, and some of the other elements render briefly while various API responses execute. We'll take this as a follow-up item as it doesn't impact functionality.

Screenshots

Destinations list page when notifications is installed, and there are no destinations.
Screen Shot 2022-12-08 at 5 22 59 PM

Destinations list page when notifications is installed, and there are un-migrated destinations.
Screen Shot 2022-12-08 at 6 08 50 PM

Destinations list page when notifications is installed, and with search filters that have no matches.
Search bar filter
Screen Shot 2022-12-08 at 6 41 58 PM
Type filter
Screen Shot 2022-12-08 at 5 26 00 PM

Destinations list page when notifications is not installed, and there are no destinations.
Screen Shot 2022-12-08 at 5 27 39 PM

Destinations list page when notifications is installed, and with search filters that have no matches.
Screen Shot 2022-12-08 at 5 26 55 PM

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…tinations list page after destinations deprecation.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…tinations list page after destinations deprecation.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Merging #413 (40318fa) into 2.3 (c1520c3) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.3     #413      +/-   ##
==========================================
+ Coverage   52.58%   52.72%   +0.13%     
==========================================
  Files         209      210       +1     
  Lines        5471     5487      +16     
  Branches      765      766       +1     
==========================================
+ Hits         2877     2893      +16     
  Misses       2592     2592              
  Partials        2        2              
Impacted Files Coverage Δ
...lugin/public/pages/Destinations/utils/constants.js 100.00% <0.00%> (ø)
...ns/containers/DestinationsList/DestinationsList.js 52.94% <0.00%> (ø)
...tificationsInfoCallOut/NotificationsInfoCallOut.js 100.00% <0.00%> (ø)
...nationsList/EmptyDestinations/EmptyDestinations.js 100.00% <0.00%> (ø)
...onsInfoCallOut/FullPageNotificationsInfoCallOut.js 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt AWSHurneyt merged commit 58dee83 into opensearch-project:2.3 Jan 10, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-413-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 58dee8375d317080102d8ef009c94cdea7883245
# Push it to GitHub
git push --set-upstream origin backport/backport-413-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0

Then, create a pull request where the base branch is 2.0 and the compare/head branch is backport/backport-413-to-2.0.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
…tinations list page after destinations deprecation. (#413)

* Refactored the help text elements displayed when users access the destinations list page after destinations deprecation.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored the help text elements displayed when users access the destinations list page after destinations deprecation.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshot.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated button text.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshot files.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored landing page logic.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
(cherry picked from commit 58dee83)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.1 2.1
# Navigate to the new working tree
cd .worktrees/backport-2.1
# Create a new branch
git switch --create backport/backport-413-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 58dee8375d317080102d8ef009c94cdea7883245
# Push it to GitHub
git push --set-upstream origin backport/backport-413-to-2.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.1

Then, create a pull request where the base branch is 2.1 and the compare/head branch is backport/backport-413-to-2.1.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.2 2.2
# Navigate to the new working tree
cd .worktrees/backport-2.2
# Create a new branch
git switch --create backport/backport-413-to-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 58dee8375d317080102d8ef009c94cdea7883245
# Push it to GitHub
git push --set-upstream origin backport/backport-413-to-2.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.2

Then, create a pull request where the base branch is 2.2 and the compare/head branch is backport/backport-413-to-2.2.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.4 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-413-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 58dee8375d317080102d8ef009c94cdea7883245
# Push it to GitHub
git push --set-upstream origin backport/backport-413-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4

Then, create a pull request where the base branch is 2.4 and the compare/head branch is backport/backport-413-to-2.4.

AWSHurneyt added a commit that referenced this pull request Jan 10, 2023
…tinations list page after destinations deprecation. (#413) (#438)

* Refactored the help text elements displayed when users access the destinations list page after destinations deprecation.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored the help text elements displayed when users access the destinations list page after destinations deprecation.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshot.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated button text.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshot files.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored landing page logic.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
(cherry picked from commit 58dee83)

Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt added a commit to AWSHurneyt/alerting-dashboards-plugin that referenced this pull request Jan 11, 2023
…tinations list page after destinations deprecation. (opensearch-project#413) (opensearch-project#438)

* Refactored the help text elements displayed when users access the destinations list page after destinations deprecation.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored the help text elements displayed when users access the destinations list page after destinations deprecation.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshot.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated button text.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshot files.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored landing page logic.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
(cherry picked from commit 58dee83)

Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt added a commit that referenced this pull request Jan 12, 2023
…tinations list page after destinations deprecation. (#413) (#438) (#443)

* Refactored the help text elements displayed when users access the destinations list page after destinations deprecation.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored the help text elements displayed when users access the destinations list page after destinations deprecation.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshot.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated button text.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshot files.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored landing page logic.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
(cherry picked from commit 58dee83)

Co-authored-by: AWSHurneyt <hurneyt@amazon.com>

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
lezzago added a commit that referenced this pull request Feb 13, 2023
* Bumped version from 2.3 to 2.4. (#346)

* Bumping version from 2.3 to 2.4.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Adjusted OSD version used by unit test workflow to last version that allowed the tests to pass.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Bumped d3-color version. (#350)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Support windows CI (#354)

* Support windows CI

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Add 2.4 release notes (#357)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Fix confidence bug (#360)

This PR fixed a bug when showing confidence in trigger definition. Confidence is usually a non-decreasing function on an interval. But we incorrectly only show confidence when the corresponding anomaly grade is larger than 0.

Testing done:
1. manually tested that the bug is fixed. See attached snapshots.
2. yarn test:jest

Signed-off-by: Kaituo Li <kaituo@amazon.com>

* Bumped loader-utils version to address dependabot alert. (#361)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* updated link to dashboards developer guide (#349)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* Fixed a bug that prevented the throttling settings from displaying for PER_ALERT bucket level trigger actions. (#328)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Adjust OpenSearch-Dashboards version used by test workflows. (#363)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* avoid nesting search inside search (#382)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* Bumped loader-utils version to address dependabot alert. (#379)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* [BUG] Issues in the UI above 200 destinations paging issue #195 (#375)

* [BUG] Issues in the UI above 200 destinations #195

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Issues in the UI above 200 destinations #195

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Issues in the UI above 200 destinations #195

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* sorted data by date (#385)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* Align all flyout components to be overlay kind and add close button X in header (#373)

* align all flyout components to overlay

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* simplify if statement

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* fix snapshot

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* add close button to flyout header, remove footer

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* simplify flex layout

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* update snapshot

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* add data-test-subject on flyout header title

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* fix cypress tests, overflow on flyout title

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* fix snapshot

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* eui-textTruncate on flyout titles

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>

* Bumped decode-uri-component version to address CVE-2022-38900. (#400)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed an issue that was causing the results of the ctx object to be empty.  (#334)

* Fixed an issue that was causing the results of the ctx object to be empty.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed an issue that was causing the results of the ctx object to be empty.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Consolidated duplicate code.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Keep monitor table cell width flexible; Check for whether monitor is enabled when displaying related action (#402)

* made table cells flexible; added monitor enabled check for actions

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated snapshot

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* minor updates

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated jest snapshots

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* Add release notes for 2.4.1 (#420)

Signed-off-by: Saurabh Singh <sisurab@amazon.com>

Signed-off-by: Saurabh Singh <sisurab@amazon.com>

* Bumped version to 2.5. (#437)

* Bumped version to 2.5.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Adjusted test workflows to not use 2.5 tag for OSD as it hasn't been created yet.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* 2.5.0 release notes. (#440)

* Drafted 2.5 release notes.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Drafted 2.5 release notes.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored the help text elements displayed when users access the destinations list page after destinations deprecation. (#413) (#438) (#443)

* Refactored the help text elements displayed when users access the destinations list page after destinations deprecation.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored the help text elements displayed when users access the destinations list page after destinations deprecation.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshot.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated button text.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshot files.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Refactored landing page logic.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
(cherry picked from commit 58dee83)

Co-authored-by: AWSHurneyt <hurneyt@amazon.com>

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>

* Fix CVE-2022-46175 (#453)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

* Updated MAINTAINERS.md to match recommended opensearch-project format. (#435)

Signed-off-by: dblock <dblock@amazon.com>

Signed-off-by: dblock <dblock@amazon.com>

* Refactored cypress and unit test workflows to use the 2.5.0 tag as the OSD repo reference. (#462)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Kaituo Li <kaituo@amazon.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Aleksandar Djindjic <djindjic@gmail.com>
Signed-off-by: Saurabh Singh <sisurab@amazon.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: dblock <dblock@amazon.com>
Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
Co-authored-by: Kaituo Li <kaituo@amazon.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Co-authored-by: Aleksandar Djindjic <djindjic@gmail.com>
Co-authored-by: Saurabh Singh <sisurab@amazon.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants