Adding the ITs for the support of Date Math Index Resolution and a fix for moving the alert to the error state in case of not being able to publish the emails #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityaj1107
changed the title
adityaj1107
changed the title
lezzago
requested changes
Jun 21, 2021
alerting/src/test/kotlin/org/opensearch/alerting/MonitorRunnerIT.kt
Outdated
Show resolved
Hide resolved
adityaj1107
changed the title
adityaj1107
changed the title
for showing error alerts in case of email message not sent
adityaj1107
changed the title
Merged
1 task
lezzago
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #74 #94
Description of changes: A null check was required to prevent the destinations which don't have a URL or a HOST as a part of the Destination Params. This resulted in validation failures whenever Destinations such as SNS are added. Added the null checks and also updated the UTs
An urgent update (hot fix) was done as a part of this commit to unblock.
This also updates the integration test to create the index which is encoded in date math format. (#74)
This also contains the fix for storing the alert in the error condition whenever the action is unable to send the email to the destination.
Changes are tested locally by hitting the APIs and checking the response of the unreachably configured SMPT server.
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.