[Backport 2.x] Added input validation, and fixed bug for cross cluster monitors. (#1510) #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensearch-project#1510) * Fixed issue where InputService wouldn't wait for cluster metrics monitor to finish executing against all clusters. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added input validation for GetRemoteIndexes API, and added related unit and integration tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed unused variable, and imports. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Made initial call to GetRemoteIndexes API log INFO level to capture timestamp of incoming request. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed comment. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Moved some regex to common utils. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Renamed cross cluster monitor setting. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed import. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed import. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed ktlint error. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added null checks for health statuses. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Wrapped Monitor.parse calls in AlertingExceptions so IllegalArgumentExceptions are wrapped in 4xx-level exceptions. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed merge error. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed test. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
|
The tests in this PR will fail until opensearch-project/common-utils#641 is merged. |
jowg-amazon
approved these changes
Apr 13, 2024
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
|
The security tests are failing due to unrelated issues. They'll be fixed in a separate PR. |
eirsep
approved these changes
Apr 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 13, 2024
…r monitors. (#1510) (#1515) * Added input validation, and fixed bug for cross cluster monitors. (#1510) * Fixed issue where InputService wouldn't wait for cluster metrics monitor to finish executing against all clusters. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added input validation for GetRemoteIndexes API, and added related unit and integration tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed unused variable, and imports. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Made initial call to GetRemoteIndexes API log INFO level to capture timestamp of incoming request. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed comment. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Moved some regex to common utils. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Renamed cross cluster monitor setting. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed import. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed import. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed ktlint error. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added null checks for health statuses. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Wrapped Monitor.parse calls in AlertingExceptions so IllegalArgumentExceptions are wrapped in 4xx-level exceptions. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed merge error. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed test. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed test. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 3f60cf1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Apr 13, 2024
…r monitors. (#1510) (#1515) (#1516) * Added input validation, and fixed bug for cross cluster monitors. (#1510) * Fixed issue where InputService wouldn't wait for cluster metrics monitor to finish executing against all clusters. * Added input validation for GetRemoteIndexes API, and added related unit and integration tests. * Removed unused variable, and imports. * Made initial call to GetRemoteIndexes API log INFO level to capture timestamp of incoming request. * Fixed comment. * Moved some regex to common utils. * Renamed cross cluster monitor setting. * Fixed import. * Fixed import. * Fixed ktlint error. * Added null checks for health statuses. * Wrapped Monitor.parse calls in AlertingExceptions so IllegalArgumentExceptions are wrapped in 4xx-level exceptions. * Fixed merge error. * Fixed test. --------- * Fixed test. --------- (cherry picked from commit 3f60cf1) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Manual backport of PR #1510
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.