Adjusted integ tests for when security is enabled. #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
requested review from
lezzago,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn,
rishabhmaurya,
engechas,
riysaxen-amzn and
jowg-amazon
as code owners
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
engechas
approved these changes
Apr 30, 2024
| assertEquals(expectedNames.size, indexes.keys.size) | ||
|
|
||
| // Skipping this assert when security is enabled as it doesn't consider the existence of system indexes. | ||
| if (!securityEnabled()) assertEquals(expectedNames.size, indexes.keys.size) |
There was a problem hiding this comment.
Nice find. We could try to compute the correct value when security is enabled rather than skipping this assert but that could end up being a moving target if new system indices are added down the line
riysaxen-amzn
approved these changes
Apr 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Adjusted integ tests for when security is enabled. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted integ tests for when security is enabled. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit e7e7725) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Adjusted integ tests for when security is enabled. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Adjusted integ tests for when security is enabled. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit e7e7725) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Adjusted integ tests for when security is enabled. * Adjusted integ tests for when security is enabled. --------- (cherry picked from commit e7e7725) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Adjusted integ tests for when security is enabled. * Adjusted integ tests for when security is enabled. --------- (cherry picked from commit e7e7725) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adjusted integ tests for when security is enabled.
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.