enable publishing of alerting-spi jar #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
sbcd90
requested review from
lezzago,
AWSHurneyt,
eirsep,
getsaurabh02,
praveensameneni,
bowenlan-amzn,
rishabhmaurya,
engechas,
riysaxen-amzn and
jowg-amazon
as code owners
eirsep
approved these changes
Jun 3, 2024
lezzago
reviewed
Jun 3, 2024
Comment on lines
+90
to
+91
| gradle.startParameter.setLogLevel(LogLevel.DEBUG) |
There was a problem hiding this comment.
Will this cause the logs to always be at debug level?
There was a problem hiding this comment.
this will just set the log level for gradle tasks. so no impact on log statements in the code.
lezzago
reviewed
Jun 3, 2024
spi/build.gradle
Outdated
Comment on lines
81
to
83
| organization = "Amazon Web Services" | ||
| organizationUrl = "https://aws.amazon.com" |
There was a problem hiding this comment.
Shouldn't this be opensearch and linking to opensearch url?
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
lezzago
approved these changes
Jun 3, 2024
AWSHurneyt
pushed a commit
to AWSHurneyt/OpenSearch-Alerting
that referenced
this pull request
Jun 25, 2024
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
sbcd90
added a commit
to sbcd90/alerting
that referenced
this pull request
Jul 3, 2024
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1546
Description of changes:
enable publishing of alerting-spi jar
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.