Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message bug to show the correct destination ID thats missing #685

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Nov 30, 2022

Signed-off-by: Ashish Agrawal ashisagr@amazon.com

Issue #, if available:
N/A

Description of changes:
When the destination or notification channel cannot be found, the error message shows the action Id instead of the destination/notification id.

CheckList:
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@lezzago lezzago merged commit 2a1a185 into opensearch-project:main Dec 20, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 20, 2022
#685)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 2a1a185)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 20, 2022
#685)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 2a1a185)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 20, 2022
#685)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 2a1a185)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 20, 2022
#685)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 2a1a185)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 20, 2022
#685)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 2a1a185)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 20, 2022
#685)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 2a1a185)
khushbr pushed a commit that referenced this pull request Dec 21, 2022
#685) (#719)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 2a1a185)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
khushbr pushed a commit that referenced this pull request Dec 21, 2022
#685) (#720)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 2a1a185)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
khushbr pushed a commit that referenced this pull request Dec 21, 2022
#685) (#718)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 2a1a185)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
khushbr pushed a commit that referenced this pull request Dec 21, 2022
#685) (#717)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 2a1a185)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
khushbr pushed a commit that referenced this pull request Dec 21, 2022
#685) (#716)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 2a1a185)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
lezzago added a commit that referenced this pull request Jan 9, 2023
#685) (#715)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 2a1a185)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants