Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate variables for alert and finding scheduled rollovers #705

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Dec 19, 2022

Signed-off-by: Ashish Agrawal ashisagr@amazon.com

Issue #, if available:
#703
Description of changes:
Seperate variables for alert and finding scheduled rollovers to prevent both tasks to get cancelled

CheckList:
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@lezzago lezzago requested a review from a team December 19, 2022 20:08
@codecov-commenter
Copy link

Codecov Report

Merging #705 (91b6624) into main (9d9f588) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main     #705      +/-   ##
============================================
- Coverage     76.35%   76.29%   -0.06%     
  Complexity      116      116              
============================================
  Files           124      124              
  Lines          6619     6620       +1     
  Branches        982      983       +1     
============================================
- Hits           5054     5051       -3     
- Misses         1066     1068       +2     
- Partials        499      501       +2     
Impacted Files Coverage Δ
...lin/org/opensearch/alerting/alerts/AlertIndices.kt 73.85% <50.00%> (-0.31%) ⬇️
...ing/model/destination/DestinationContextFactory.kt 75.00% <0.00%> (-3.58%) ⬇️
...rch/alerting/opensearchapi/OpenSearchExtensions.kt 50.00% <0.00%> (-1.62%) ⬇️
...destinationmigration/DestinationConversionUtils.kt 71.11% <0.00%> (-1.12%) ⬇️
...nationmigration/DestinationMigrationUtilService.kt 81.45% <0.00%> (-0.81%) ⬇️
...ain/kotlin/org/opensearch/alerting/AlertService.kt 79.06% <0.00%> (+0.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lezzago lezzago merged commit 41265f8 into opensearch-project:main Dec 20, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 20, 2022
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 41265f8)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 20, 2022
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 41265f8)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 20, 2022
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 41265f8)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 20, 2022
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 41265f8)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 20, 2022
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 41265f8)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 20, 2022
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 41265f8)
khushbr pushed a commit that referenced this pull request Dec 21, 2022
…714)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 41265f8)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
khushbr pushed a commit that referenced this pull request Dec 21, 2022
…712)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 41265f8)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
khushbr pushed a commit that referenced this pull request Dec 21, 2022
…711)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 41265f8)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
khushbr pushed a commit that referenced this pull request Dec 21, 2022
…710)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 41265f8)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
lezzago added a commit that referenced this pull request Dec 21, 2022
…713)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 41265f8)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
lezzago added a commit that referenced this pull request Jan 9, 2023
…709)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 41265f8)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants