Skip to content

Commit

Permalink
Remove unnecessary sleep between test runs (#746) (#754)
Browse files Browse the repository at this point in the history
The introduction of `sleep` between test runs in `dashboard_spec.js` and `detector_list_spec.js` was initially implemented to handle timing issues. However, these tests were actually failing due to a recent URL change, as detailed in opensearch-project/opensearch-dashboards-functional-test#1257.

With the root cause of the failures addressed, the delays introduced by `sleep` commands are now redundant and can potentially slow down the testing process without providing any benefit. This PR removes these unnecessary sleep intervals between test executions.

**Testing Done:**
- Confirmed that all remote Cypress tests pass without the sleep intervals.

Signed-off-by: Kaituo Li <kaituo@amazon.com>
(cherry picked from commit e509a03)

Co-authored-by: Kaituo Li <kaituo@amazon.com>
  • Loading branch information
opensearch-trigger-bot[bot] and kaituo committed May 1, 2024
1 parent 70d4183 commit a6fa630
Showing 1 changed file with 6 additions and 11 deletions.
17 changes: 6 additions & 11 deletions .github/workflows/remote-integ-tests-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -140,21 +140,16 @@ jobs:
- name: Finding spec files and store to output
id: finding-files
run: |
echo "::set-output name=FILELIST::$(find cypress/integration/plugins/anomaly-detection-dashboards-plugin -name '*.js' -print)"
working-directory: opensearch-dashboards-functional-test

- name: Print spec files from output
run: |
IFS="," read -a myarray <<< ${{ steps.finding-files.outputs.FILELIST }}
for i in "${myarray[@]}"; do
echo "${i}"
done
{
echo 'FILELIST<<EOF'
find cypress/integration/plugins/anomaly-detection-dashboards-plugin -name '*.js' -print
echo EOF
} >> "$GITHUB_ENV"
working-directory: opensearch-dashboards-functional-test

- name: Run spec files from output
run: |
IFS="," read -a myarray <<< ${{ steps.finding-files.outputs.FILELIST }}
for i in "${myarray[@]}"; do
for i in $FILELIST; do
yarn cypress:run-without-security --browser electron --spec "${i}"
sleep 60
done
Expand Down

0 comments on commit a6fa630

Please sign in to comment.