Optimize fetching of augment-vis saved objects
#562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
requested review from
kaituo,
jackiehanyang,
amitgalitz and
sean-zheng-amazon
as code owners
jackiehanyang
approved these changes
Jul 20, 2023
Codecov Report
@@ Coverage Diff @@
## main #562 +/- ##
==========================================
+ Coverage 50.25% 50.28% +0.02%
==========================================
Files 166 166
Lines 5593 5590 -3
Branches 1055 1055
==========================================
Hits 2811 2811
+ Misses 2511 2508 -3
Partials 271 271 |
amitgalitz
approved these changes
Jul 20, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 20, 2023
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit a334f08)
This was referenced Jul 20, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 20, 2023
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit a334f08)
ohltyler
added a commit
that referenced
this pull request
Jul 20, 2023
ohltyler
added a commit
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates saved object loader
findAll()calls to include ahasReferenceargument so only objects that include the desired vis ID as a reference will be fetched. Part of opensearch-project/OpenSearch-Dashboards#4595.Other line changes are formatting done by
prettier.Tested against cluster with the change in OSD, works as expected.
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.