Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change build workflows to run on production docker image #620

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Change build workflows to run on production docker image #620

merged 1 commit into from
Oct 18, 2023

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Oct 10, 2023 •
edited
Loading

Description

Change build and test workflows to run on production docker image. Note that for now, only linux containers are supported by GitHub actions, so we split up the steps into multiple - one for linux, and another for windows & macos.

Also, adds a build step to the test workflow and renames the workflow to reflect that.

Issues Resolved

Resolves #614

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler ohltyler added test Adding or fixing tests github actions Updating or adding GitHub actions backport 2.x labels Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Merging #620 (4511bc4) into main (8c3ed81) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 4511bc4 differs from pull request most recent head e5667f6. Consider uploading reports for the commit e5667f6 to get more accurate results

@@           Coverage Diff           @@
##             main     #620   +/-   ##
=======================================
  Coverage   50.31%   50.31%           
=======================================
  Files         166      166           
  Lines        5593     5593           
  Branches     1074     1074           
=======================================
  Hits         2814     2814           
  Misses       2508     2508           
  Partials      271      271

@ohltyler
Copy link
Member Author

New job is passing, and the build-and-test workflow running in the container has passed.

@ohltyler ohltyler mentioned this pull request Oct 12, 2023
Closed
@ohltyler
Copy link
Member Author

Created #627 to track the test workflow changes.

joshpalis
joshpalis previously approved these changes Oct 12, 2023
View reviewed changes
@ohltyler ohltyler marked this pull request as draft October 16, 2023 15:52
@ohltyler
Copy link
Member Author

Converting to draft until #614 (comment) is resolved.

@peterzhuamazon
Copy link
Member

I will start adding changes to this PR soon.
Thanks.

@ohltyler @peterzhuamazon
Support github actions to run yarn build on build docker images
e5667f6 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon marked this pull request as ready for review October 17, 2023 22:38
@peterzhuamazon peterzhuamazon mentioned this pull request Oct 17, 2023
Closed
@peterzhuamazon
Copy link
Member

Ready for review.

cc: @ohltyler

Thanks.

@peterzhuamazon peterzhuamazon changed the title Change build and test workflows to run on production docker image Change build workflows to run on production docker image Oct 17, 2023
@ohltyler
Copy link
Member Author

Removing backport tag since we'll need a manual commit with updated value for OPENSEARCH_DASHBOARDS_VERSION

@ohltyler
Copy link
Member Author

I'll collect 2 reviewers as I can't approve my (technically own) PR :)

@ohltyler ohltyler merged commit 2c5a7e3 into opensearch-project:main Oct 18, 2023
4 of 9 checks passed
@ohltyler ohltyler deleted the docker-ci branch October 18, 2023 23:58
ohltyler added a commit to ohltyler/anomaly-detection-dashboards-plugin-1 that referenced this pull request Oct 19, 2023
@ohltyler
Support github actions to run yarn build on build docker images (open…
861d3f9 
…search-project#620)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@ohltyler ohltyler mentioned this pull request Oct 19, 2023
Merged
@ohltyler
Copy link
Member Author

2.x backport: #628

ohltyler added a commit that referenced this pull request Oct 19, 2023
@ohltyler
Support github actions to run yarn build on build docker images (#620) (
68ca890 
#628)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaituo kaituo kaituo approved these changes

@joshpalis joshpalis joshpalis approved these changes

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@sean-zheng-amazon sean-zheng-amazon Awaiting requested review from sean-zheng-amazon sean-zheng-amazon is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@sudiptoguha sudiptoguha Awaiting requested review from sudiptoguha

Assignees
No one assigned
Labels
github actions Updating or adding GitHub actions test Adding or fixing tests
Projects
OpenSearch Engineering Effectiveness
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Campaign] Ensure Github workflow runs on docker image used by Production Distribution Build
4 participants
@ohltyler @peterzhuamazon @kaituo @joshpalis