make jvm heap usage a dynamic setting #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
jackiehanyang
requested review from
jmazanec15,
jngz-es,
kaituo,
saratvemulapalli,
ohltyler,
vamshin,
VijayanB,
ylwu-amzn,
amitgalitz,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
kaituo
reviewed
May 28, 2024
| import org.opensearch.common.settings.Setting; | ||
| import org.opensearch.timeseries.settings.DynamicNumericSetting; | ||
|
|
||
| public class MemoryCircuitBreakerNumericSetting extends DynamicNumericSetting { |
There was a problem hiding this comment.
Can you move your code to ADNumericSetting ? We don't need to create a new class for each setting. Also, we covered setting init in TimeSeriesAnalyticsPlugin. Once you moved your code to ADNumericSetting, we don't need another call to initialize memory circuit breaker setting.
There was a problem hiding this comment.
moved the logic to ADNumericSetting file in the latest revision
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Will do an e2d test when both 2.15 changes are done. Tracking it here - #1213 |
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
kaituo
approved these changes
May 29, 2024
|
did e2e testing and verified result with Kaituo offline |
jackiehanyang
merged commit 2ce5a7c
into
opensearch-project:main
21 of 25 checks passed
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/anomaly-detection/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/anomaly-detection/backport-2.x
# Create a new branch
git switch --create backport/backport-1212-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2ce5a7c96420513c8a88fb91257577f40a79cee9
# Push it to GitHub
git push --set-upstream origin backport/backport-1212-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/anomaly-detection/backport-2.xThen, create a pull request where the |
jackiehanyang
added a commit
to jackiehanyang/anomaly-detection
that referenced
this pull request
Jun 3, 2024
* make jvm heap usage a dynamic setting Signed-off-by: Jackie Han <jkhanjob@gmail.com> * move jvm_heap_usage_threshold setting to ADNumericSetting file Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update jvm threshold setting name Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> (cherry picked from commit 2ce5a7c)
jackiehanyang
added a commit
to jackiehanyang/anomaly-detection
that referenced
this pull request
Jun 3, 2024
* make jvm heap usage a dynamic setting Signed-off-by: Jackie Han <jkhanjob@gmail.com> * move jvm_heap_usage_threshold setting to ADNumericSetting file Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update jvm threshold setting name Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> (cherry picked from commit 2ce5a7c)
jackiehanyang
added a commit
that referenced
this pull request
Jun 4, 2024
* make jvm heap usage a dynamic setting Signed-off-by: Jackie Han <jkhanjob@gmail.com> * move jvm_heap_usage_threshold setting to ADNumericSetting file Signed-off-by: Jackie Han <jkhanjob@gmail.com> * update jvm threshold setting name Signed-off-by: Jackie Han <jkhanjob@gmail.com> --------- Signed-off-by: Jackie Han <jkhanjob@gmail.com> (cherry picked from commit 2ce5a7c) Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make jvm heap usage a dynamic setting
Issues Resolved
#1213
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.