Rename namespaces from opendistro to opensearch. #43
Conversation
Signed-off-by: Alex <pengsun@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #43 +/- ##
=========================================
Coverage 79.25% 79.26%
- Complexity 2690 2691 +1
=========================================
Files 242 242
Lines 11065 11065
Branches 1012 1012
=========================================
+ Hits 8770 8771 +1
Misses 1880 1880
+ Partials 415 414 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| import com.amazon.opendistroforelasticsearch.ad.transport.AnomalyResultTransportAction; | ||
| import com.amazon.opendistroforelasticsearch.ad.transport.handler.AnomalyIndexHandler; | ||
| import com.amazon.opendistroforelasticsearch.ad.transport.handler.DetectionStateHandler; | ||
| import com.amazon.opendistroforelasticsearch.ad.util.ClientUtil; | ||
| import com.amazon.opendistroforelasticsearch.commons.InjectSecurity; |
There was a problem hiding this comment.
Should we wait for the AD dependencies (common-utils, job-scheduler) to make the corresponding namespace changes first? Then we can remove all references to opendistroforelasticsearch?
There was a problem hiding this comment.
Good point!
But considering the tight launch schedule, I prefer to change as much as we could before the AD dependencies were ready. Once the dependencies were ready, we could make another small change to remove all references to opendistroforelasticsearch.
There was a problem hiding this comment.
line 76 to 83 of this file still using com.amazon.opendistroforelasticsearch.* as common-utils and job-scheduler not changed yet.
I think it's ok to change it later when common-utils and job-scheduler ready. So we can make sure AD build can pass.
There was a problem hiding this comment.
Cool, it can be fixed after. Created #45 to track.
There was a problem hiding this comment.
opensearch-project/common-utils#19 and opensearch-project/job-scheduler#22 are being taken of
jcgraybill
removed this from OpenSearch 1.3 (November 29)
in OpenSearch Project Roadmap
Signed-off-by: Alex pengsun@amazon.com
Description
Rename namespaces & other references of opendistro to opensearch
Issues Resolved
Update the namespaces to adopt the opensearch GA.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.