Rename classes, variables, methods to incorporate OpenSearch #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested changes
May 19, 2021
| @@ -42,7 +42,7 @@ public AuthUserRequestBuilder(String auth) { | |||
| } | |||
|
|
|||
| public Request build() { | |||
| Request request = new Request("GET", "/_opendistro/_security/authinfo"); | |||
| Request request = new Request("GET", "/_opensearch/_security/authinfo"); | |||
There was a problem hiding this comment.
You need to track this down in the security plugin and make sure that this is the change that was made there. I think the path is different.
There was a problem hiding this comment.
Security plugin has not yet updated the path. I restored it to the original _opendistro path till security makes the changes. There are several other security settings that will also need to be changed once security plugin makes the change.
There was a problem hiding this comment.
Please open an issue in this repo to change this later, linking to an issue in security to watch.
There was a problem hiding this comment.
Sure I have opened a new issue in this repo #22.
Signed-off-by: Vacha Shah <vachshah@amazon.com>
VachaShah
force-pushed
the
rename_classes_variables_methods
branch
from
0d65989
to
3bb9ef1
Compare
dblock
approved these changes
May 19, 2021
wuychn
pushed a commit
to ochprince/common-utils
that referenced
this pull request
Mar 16, 2023
…rch-project#21) Signed-off-by: Vacha Shah <vachshah@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vacha Shah vachshah@amazon.com
Description
This PR updates the classes, variables, methods to incorporate OpenSearch.
Issues Resolved
Part 2 of #19
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.