Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ctx variables #318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

partlov
Copy link

@partlov partlov commented Nov 10, 2022

Signed-off-by: Petar Partlov partlov@gmail.com

Description

Added missing fields to ctx so content is aligned with documentation and our plans.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@partlov partlov force-pushed the bug/fix_missing_ctx_variables branch 2 times, most recently from 0a19c74 to 7cba7ae Compare November 10, 2022 13:30
@partlov partlov changed the title Add missing ctx variables alerting#200 Add missing ctx variables opensearch-project/alerting#200 Nov 10, 2022
@partlov partlov changed the title Add missing ctx variables opensearch-project/alerting#200 Add missing ctx variables Nov 10, 2022
@partlov partlov force-pushed the bug/fix_missing_ctx_variables branch 11 times, most recently from 03560d9 to 5868ab4 Compare November 15, 2022 18:55
@partlov partlov marked this pull request as ready for review November 15, 2022 21:45
@partlov partlov requested a review from a team November 15, 2022 21:45
@lezzago
Copy link
Member

lezzago commented Apr 6, 2023

We need to rebase. If the external contributor can't update this, someone from the Alerting team will take it

- Issue opensearch-project/alerting#200

Signed-off-by: Petar Partlov <partlov@gmail.com>
@partlov partlov force-pushed the bug/fix_missing_ctx_variables branch from 5868ab4 to ccddedf Compare April 6, 2023 17:49
@partlov
Copy link
Author

partlov commented Apr 6, 2023

We need to rebase. If the external contributor can't update this, someone from the Alerting team will take it

Rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants