Add version info to build.gradle #5
Conversation
build.gradle
Outdated
| @@ -39,6 +41,17 @@ repositories { | |||
| maven { url "https://aws.oss.sonatype.org/content/repositories/snapshots" } | |||
| } | |||
|
|
|||
| allprojects { | |||
| group 'org.opensearch.index.codec.customcodecs' | |||
There was a problem hiding this comment.
Shouldn't the group be org.opensearch.plugin (https://github.com/opensearch-project/OpenSearch/blob/main/plugins/build.gradle)?
There was a problem hiding this comment.
I'm honestly not sure. I followed the convention here: https://github.com/opensearch-project/common-utils/blob/main/build.gradle#L44
There was a problem hiding this comment.
I think it should be org.opensearch per the example here: https://github.com/opensearch-project/opensearch-plugins/blob/main/BUILDING.md#define-a-version-based-on-the-opensearch-dependency
There was a problem hiding this comment.
|
This should help test it out https://github.com/opensearch-project/opensearch-plugins/blob/main/WORKFLOWS.md#publishing-java-plugins-snapshots |
This attempts to follow the conventions defined [here][1]. [1]: https://github.com/opensearch-project/opensearch-plugins/blob/main/CONVENTIONS.md Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross
force-pushed
the
version-info
branch
from
fbccd79
to
63166af
Compare
|
I'm merging this now to unblock initial integration testing. We can revisit the specific values here if they turn out to be incorrect. |
* Add gradle check workflow (#4) Signed-off-by: Andrew Ross <andrross@amazon.com> * Add add-untriaged GitHub workflow (#6) Signed-off-by: Andrew Ross <andrross@amazon.com> * Add version info to build.gradle (#5) This attempts to follow the conventions defined [here][1]. [1]: https://github.com/opensearch-project/opensearch-plugins/blob/main/CONVENTIONS.md Signed-off-by: Andrew Ross <andrross@amazon.com> --------- Signed-off-by: Andrew Ross <andrross@amazon.com>
* Add gradle check workflow (#4) Signed-off-by: Andrew Ross <andrross@amazon.com> * Add add-untriaged GitHub workflow (#6) Signed-off-by: Andrew Ross <andrross@amazon.com> * Add version info to build.gradle (#5) This attempts to follow the conventions defined [here][1]. [1]: https://github.com/opensearch-project/opensearch-plugins/blob/main/CONVENTIONS.md Signed-off-by: Andrew Ross <andrross@amazon.com> --------- Signed-off-by: Andrew Ross <andrross@amazon.com>
I copied this approach from other plugin repos, for example common-utils.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.