Rename visibility layer

Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
opensearch-project · Jan 31, 2023 · 1c0e433 · 1c0e433
1 parent 2175dd5
commit 1c0e433
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/public/components/layer_control_panel/layer_control_panel.tsx b/public/components/layer_control_panel/layer_control_panel.tsx
@@ -48,7 +48,7 @@ import {
 } from '../../model/layerRenderController';
 import { MapState } from '../../model/mapState';
 import { ConfigSchema } from '../../../common/config';
-import {moveLayers, updateVisibility} from "../../model/map/layer_operations";
+import {moveLayers, updateLayerVisibility} from "../../model/map/layer_operations";
 
 interface MaplibreRef {
   current: Maplibre | null;
@@ -290,7 +290,7 @@ export const LayerControlPanel = memo(
         layer.visibility = LAYER_VISIBILITY.VISIBLE;
         setLayerVisibility(new Map(layerVisibility.set(layer.id, true)));
       }
-      updateVisibility(maplibreRef.current!, layer.id, layer.visibility);
+      updateLayerVisibility(maplibreRef.current!, layer.id, layer.visibility);
     };
 
     const onDeleteLayerIconClick = (layer: MapLayerSpecification) => {

diff --git a/public/model/documentLayerFunctions.ts b/public/model/documentLayerFunctions.ts
@@ -17,7 +17,7 @@ import {
   updateCircleLayer,
   updateLineLayer,
   updatePolygonLayer,
-  updateVisibility,
+  updateLayerVisibility,
 } from './map/layer_operations';
 
 interface MaplibreRef {
@@ -240,7 +240,4 @@ export const DocumentLayerFunctions = {
   remove: (maplibreRef: MaplibreRef, layerConfig: DocumentLayerSpecification) => {
     removeLayers(maplibreRef.current!, layerConfig.id, true);
   },
-  hide: (maplibreRef: MaplibreRef, layerConfig: DocumentLayerSpecification) => {
-    updateVisibility(maplibreRef.current!, layerConfig.id, layerConfig.visibility);
-  },
 };
diff --git a/public/model/map/layer_operations.test.ts b/public/model/map/layer_operations.test.ts
@@ -10,7 +10,7 @@ import {
   hasLayer, moveLayers, removeLayers,
   updateCircleLayer,
   updateLineLayer,
-  updatePolygonLayer, updateVisibility,
+  updatePolygonLayer, updateLayerVisibility,
 } from './layer_operations';
 import { Map as Maplibre } from 'maplibre-gl';
 import { MockMaplibreMap } from './__mocks__/map';
@@ -366,7 +366,7 @@ describe('update visibility', function () {
     const mockLayer2: MockLayer = new MockLayer('layer-11');
     mockLayer1.setProperty('visibility', 'none');
     const mockMap: MockMaplibreMap = new MockMaplibreMap([mockLayer1, mockLayer2]);
-    updateVisibility((mockMap as unknown) as Maplibre, 'layer-1', 'visible');
+    updateLayerVisibility((mockMap as unknown) as Maplibre, 'layer-1', 'visible');
     expect(mockMap.getLayers().map((layer) => String(layer.getProperty('visibility')))).toEqual(
       Array(2).fill('visible')
     );

diff --git a/public/model/map/layer_operations.ts b/public/model/map/layer_operations.ts
@@ -42,7 +42,7 @@ export const removeLayers = (map: Maplibre, layerId: string, removeSource?: bool
   }
 };
 
-export const updateVisibility = (map: Maplibre, layerId: string, visibility: string) => {
+export const updateLayerVisibility = (map: Maplibre, layerId: string, visibility: string) => {
   getLayers(map, layerId).forEach((layer) => {
     map.setLayoutProperty(layer.id, 'visibility', visibility);
   });