Support geo_shape visualization in documents layer #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
reviewed
Dec 7, 2022
maps_dashboards/public/components/layer_config/documents_config/document_layer_style.tsx
Outdated
Show resolved
Hide resolved
VijayanB
reviewed
Dec 7, 2022
maps_dashboards/public/components/layer_config/documents_config/document_layer_style.tsx
Outdated
Show resolved
Hide resolved
VijayanB
reviewed
Dec 7, 2022
maps_dashboards/public/components/layer_config/documents_config/document_layer_style.tsx
Outdated
Show resolved
Hide resolved
|
Shall we add Marker Size to points ? |
Agree, on UX mock, I didn't find this option, will update PR to add. |
|
By default, marker size is 5. |
VijayanB
previously approved these changes
Dec 7, 2022
junqiu-lei
dismissed stale reviews from martin-gaievski and VijayanB
via
a1c22cf
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei
force-pushed
the
documents_geo_shape
branch
from
a1c22cf
to
605dbc2
Compare
VijayanB
approved these changes
Dec 7, 2022
martin-gaievski
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Junqiu Lei junqiu@amazon.com
Description
Support geo_shape visualization on documents layer in GeoJSON type.
Issues Resolved
#100
Demo
geo-shape-documents.mov
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.