Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer guide and easy setup #12

Merged
merged 5 commits into from Jun 23, 2022

Conversation

Shivamdhar
Copy link
Contributor

Signed-off-by: Shivam Dhar dhshivam@amazon.com

Description

Adds developer guide and changes the repo to work from within OSD.

Aim of the PR is:

  • to run all the yarn commands from within OSD by adding the plugin
  • to raise PRs from the plugin folder within OSD

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shivam Dhar <dhshivam@amazon.com>
@Shivamdhar Shivamdhar requested a review from a team June 22, 2022 17:29
Signed-off-by: Shivam Dhar <dhshivam@amazon.com>
Signed-off-by: Shivam Dhar <dhshivam@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #12 (76ea399) into main (31dc140) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files           4        4           
  Lines         123      123           
  Branches       19       19           
=======================================
  Hits          111      111           
  Misses          8        8           
  Partials        4        4           
Impacted Files Coverage Δ
...rt_map/public/components/vector_upload_options.tsx 90.47% <ø> (ø)
src/plugins/custom_import_map/public/services.ts 80.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31dc140...76ea399. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants