Add map as embeddable to dashboard #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #231 +/- ##
==========================================
+ Coverage 91.66% 91.79% +0.12%
==========================================
Files 10 10
Lines 264 268 +4
Branches 34 34
==========================================
+ Hits 242 246 +4
Misses 16 16
Partials 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
junqiu-lei
force-pushed
the
embeddable_1
branch
from
245f7a8
to
fa30f8f
Compare
VijayanB
reviewed
Feb 7, 2023
VijayanB
reviewed
Feb 7, 2023
VijayanB
reviewed
Feb 7, 2023
VijayanB
reviewed
Feb 7, 2023
junqiu-lei
force-pushed
the
embeddable_1
branch
2 times, most recently
from
eb1e344
to
9fe327f
Compare
ananzh
reviewed
Feb 13, 2023
junqiu-lei
force-pushed
the
embeddable_1
branch
2 times, most recently
from
4f178f4
to
d319385
Compare
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei
force-pushed
the
embeddable_1
branch
from
d319385
to
2218279
Compare
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei
force-pushed
the
embeddable_1
branch
from
2218279
to
cb7f6d0
Compare
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
VijayanB
reviewed
Feb 16, 2023
VijayanB
reviewed
Feb 16, 2023
junqiu-lei
force-pushed
the
embeddable_1
branch
from
2621a43
to
ea4e575
Compare
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei
force-pushed
the
embeddable_1
branch
from
ea4e575
to
5b0aa8a
Compare
VijayanB
reviewed
Feb 17, 2023
ananzh
reviewed
Feb 19, 2023
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei
force-pushed
the
embeddable_1
branch
from
6890102
to
c7f84bd
Compare
|
The CI test failures aren’t related to this PR. Followed from opensearch-project/opensearch-build#3210 Unit tests and Cypress tests all passed at my local env |
VijayanB
reviewed
Feb 20, 2023
|
From opensearch-project/oui#292 (comment), we will continue to use |
VijayanB
approved these changes
Feb 20, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 20, 2023
* Add map as embeddable to dashboard Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Create new map from dashboard visualization and save return Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Enable interval refresh in dashboard Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Enable filters in dashboard Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Enable query in dashboard Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Add cypress test Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Fix maps listing in visualization listing page Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Refactor controller Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Resolve feedback Signed-off-by: Junqiu Lei <junqiu@amazon.com> --------- Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit e48407b)
junqiu-lei
added a commit
that referenced
this pull request
Feb 21, 2023
* Add map as embeddable to dashboard Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Create new map from dashboard visualization and save return Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Enable interval refresh in dashboard Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Enable filters in dashboard Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Enable query in dashboard Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Add cypress test Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Fix maps listing in visualization listing page Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Refactor controller Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Resolve feedback Signed-off-by: Junqiu Lei <junqiu@amazon.com> --------- Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit e48407b) Co-authored-by: Junqiu Lei <junqiu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Junqiu Lei junqiu@amazon.com
Description
Allow user to add maps to dashboard. This PR contains:
Demo
Add existing map to dashboard
Screen.Recording.2023-02-07.at.11.55.47.AM.mov
Add new map from dashboard
Screen.Recording.2023-02-13.at.12.50.35.PM.mov
Issues Resolved
#214
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.