Add tooltip to draw shape filter #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
force-pushed
the
add-tooltip-filter
branch
2 times, most recently
from
ef27257
to
b759a13
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #330 +/- ##
=======================================
Coverage ? 84.17%
=======================================
Files ? 17
Lines ? 436
Branches ? 58
=======================================
Hits ? 367
Misses ? 52
Partials ? 17 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
VijayanB
force-pushed
the
add-tooltip-filter
branch
from
b759a13
to
773b6f0
Compare
1. Changes cursor 2. Add instruction on how to proceed. 3. Revert once cancel is seleted. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
ruanyl
reviewed
Mar 9, 2023
| @@ -265,6 +266,7 @@ export const MapContainer = ({ | |||
| {mounted && tooltipState === TOOLTIP_STATE.DISPLAY_FEATURES && ( | |||
| <DisplayFeatures map={maplibreRef.current!} layers={layers} /> | |||
| )} | |||
| {mounted && <DrawTooltip map={maplibreRef.current!} mode={filterProperties.mode} />} | |||
There was a problem hiding this comment.
I'd rather do this instead of non-null assertion, that usually leads to runtime exceptions.
mounted && Boolean(maplibreRef.current) && <DrawTooltip map={maplibreRef.current} mode={filterProperties.mode} />
There was a problem hiding this comment.
My bad, actually we can only get rid of non-null assertion if we do this:
mounted && maplibreRef.current && <DrawTooltip map={maplibreRef.current} mode={filterProperties.mode} />Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
add-tooltip-filter
branch
from
773b6f0
to
82f9e61
Compare
ruanyl
approved these changes
Mar 10, 2023
martin-gaievski
approved these changes
Mar 10, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
* Add tooltip to draw filter shape 1. Changes cursor 2. Add instruction on how to proceed. 3. Revert once cancel is selected. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit 3a20e81)
junqiu-lei
pushed a commit
that referenced
this pull request
Mar 10, 2023
* Add tooltip to draw filter shape 1. Changes cursor 2. Add instruction on how to proceed. 3. Revert once cancel is selected. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit 3a20e81) Co-authored-by: Vijayan Balasubramanian <vijayan.balasubramanian@gmail.com>
VijayanB
pushed a commit
to VijayanB/dashboards-maps
that referenced
this pull request
Mar 20, 2023
…-project#337) * Add tooltip to draw filter shape 1. Changes cursor 2. Add instruction on how to proceed. 3. Revert once cancel is selected. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit 3a20e81) Co-authored-by: Vijayan Balasubramanian <vijayan.balasubramanian@gmail.com> (cherry picked from commit c8523be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tooltip with instruction how to draw filter on map. This will not allow user to draw. It just provides
instructions on how to draw filter based on selection.
Issues Resolved
#213
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Screen.Recording.2023-03-07.at.10.14.07.PM.mov