Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update max supported layer count #332

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

VijayanB
Copy link
Member

@VijayanB VijayanB commented Mar 8, 2023

Description

Since layer panel has scroll bar, we can allow user to add up to 100. Later, this will be moved to map settings.

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Since layer panel has scroll bar, we can
allow user to add up to 100.
Later, this will be moved to map settings.

Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
@VijayanB VijayanB requested a review from a team March 8, 2023 18:25
@VijayanB VijayanB self-assigned this Mar 8, 2023
@VijayanB VijayanB added enhancement New feature or request backport 2.x labels Mar 8, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@9fffd01). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage        ?   84.17%           
=======================================
  Files           ?       17           
  Lines           ?      436           
  Branches        ?       58           
=======================================
  Hits            ?      367           
  Misses          ?       52           
  Partials        ?       17           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@VijayanB VijayanB merged commit d0f9e7b into opensearch-project:main Mar 8, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 8, 2023
Since layer panel has scroll bar, we can
allow user to add up to 100.
Later, this will be moved to map settings.

Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
(cherry picked from commit d0f9e7b)
junqiu-lei pushed a commit that referenced this pull request Mar 8, 2023
Since layer panel has scroll bar, we can
allow user to add up to 100.
Later, this will be moved to map settings.

Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
(cherry picked from commit d0f9e7b)

Co-authored-by: Vijayan Balasubramanian <vijayan.balasubramanian@gmail.com>
VijayanB pushed a commit to VijayanB/dashboards-maps that referenced this pull request Mar 20, 2023
…-project#334)

Since layer panel has scroll bar, we can
allow user to add up to 100.
Later, this will be moved to map settings.

Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
(cherry picked from commit d0f9e7b)

Co-authored-by: Vijayan Balasubramanian <vijayan.balasubramanian@gmail.com>
(cherry picked from commit 2da38d5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants