Clean console indexPatterns api error #418
Conversation
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei
added
backport 2.x
skip-changelog
backport 2.8
junqiu-lei
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda and
martin-gaievski
as code owners
junqiu-lei
changed the title
Codecov Report
@@ Coverage Diff @@
## main #418 +/- ##
=======================================
Coverage 41.36% 41.36%
=======================================
Files 53 53
Lines 1777 1777
Branches 329 329
=======================================
Hits 735 735
Misses 1014 1014
Partials 28 28 |
| // @ts-ignore | ||
| const newIndexPattern = await indexPatterns.get(selectedLayerConfig.source.indexPatternId); | ||
| const newIndexPattern = await services.data.indexPatterns.get( | ||
| // @ts-ignore |
There was a problem hiding this comment.
Is this by mistake or intentional? having comment inside method parameter seems weird.
There was a problem hiding this comment.
Intentional for the below line
| @@ -241,8 +241,10 @@ export const MapContainer = ({ | |||
| (indexPattern) => indexPattern.id === selectedLayerConfig.source.indexPatternId | |||
| ); | |||
| if (!findIndexPattern) { | |||
| // @ts-ignore | |||
| const newIndexPattern = await indexPatterns.get(selectedLayerConfig.source.indexPatternId); | |||
| const newIndexPattern = await services.data.indexPatterns.get( | |||
There was a problem hiding this comment.
I just couldn't match commit message and this code change.
Correct indexPatterns api from services.data.indexPatterns to clean browser console error.
but the code is changing indexPatterns to services.data.indexPatterns
There was a problem hiding this comment.
The method is used to update layersIndexPatterns which is only used in top nav comment as a requirement prop, but no use there currently(it's mainly used for global filter, we don't support yet).
It used to be passed in by:
const {
data: { indexPatterns },
} = services;
so it's the reason we change from indexPatterns to services.data.indexPatterns
There was a problem hiding this comment.
Got it. So it is Use indexPatterns api from services.data.indexPatterns to clean browser console error.
Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit 485ef36)
Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit 485ef36)
Description
Use indexPatterns api from services.data.indexPatterns to clean browser console error
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.