Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cluster layer #423

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

raintygao
Copy link
Contributor

@raintygao raintygao commented Jun 2, 2023

Description

add cluster layer

Issues Resolved

#250

Demo

2023-06-08.15.40.58.mov

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: raintygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #423 (1f18152) into main (485ef36) will decrease coverage by 4.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   41.36%   36.71%   -4.65%     
==========================================
  Files          53       69      +16     
  Lines        1777     2285     +508     
  Branches      329      406      +77     
==========================================
+ Hits          735      839     +104     
- Misses       1014     1418     +404     
  Partials       28       28              

see 27 files with indirect coverage changes

@raintygao
Copy link
Contributor Author

Hi @VijayanB, will your team review this PR to catch an upcoming release?

@fredle
Copy link

fredle commented Jan 4, 2024

@raintygao I have tested this branch and it is exactly what we are looking for. Is there any way we can get PR back on the agenda?

@raintygao
Copy link
Contributor Author

raintygao commented Jan 8, 2024

I have tested this branch and it is exactly what we are looking for. Is there any way we can get PR back on the agenda?

Hi, I'm willing to push forward this PR but I may not have any extra time recently due to focusing on other projects. I think this feature is important, it also depends on the team's plan. cc @nandi-github @junqiu-lei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants