Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed maps tooltip display at dark mode #564

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

junqiu-lei
Copy link
Member

@junqiu-lei junqiu-lei commented Nov 30, 2023

Description

Followed from #458 (comment), this PR:

  1. Removes the redundant padding on tooltip
  2. Changes the scroll bar to automatically display on tooltip

Test

Before:
image

After:
image

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kgcreative
Copy link
Member

I still see a white triangle at the bottom of the tooltip in darkmode. (just a minor nitpick)

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
VijayanB
VijayanB previously approved these changes Nov 30, 2023
@junqiu-lei
Copy link
Member Author

I still see a white triangle at the bottom of the tooltip in darkmode. (just a minor nitpick)

@kgcreative Thanks, updated this part

@kgcreative
Copy link
Member

I still see a white triangle at the bottom of the tooltip in darkmode. (just a minor nitpick)

@kgcreative Thanks, updated this part

LGTM!

@junqiu-lei junqiu-lei merged commit 843c1fc into opensearch-project:main Dec 1, 2023
6 of 11 checks passed
@junqiu-lei junqiu-lei deleted the dark-style branch December 1, 2023 01:17
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 1, 2023
@canascar
Copy link
Member

canascar commented Dec 1, 2023

I still see a white triangle at the bottom of the tooltip in darkmode. (just a minor nitpick)

@kgcreative Thanks, updated this part

LGTM!

We may have to see how this popover is implemented. Is it hard coded or using the popover component? Works for now but the border does not appear to be merged with and applied to the popover arrow indicator:
Screenshot 2023-12-01 at 12 22 51 PM

  1. Appears as if the dropshadow is within the contents of the popover (panel?) and not the tooltip - which is missing the dropshadow here.
  2. The border does not seem to be applied to the popover but rather the contents inside (panel?)

VS
Screenshot 2023-12-01 at 12 22 25 PM
Reference:
https://oui.opensearch.org/1.3/#/layout/popover
Popover should have a border and dropshadow applied. Contents within should not contain surrounding (container) borders or shadows.

--- Also, this issue is not just in Dark mode as stated in here:
#563

@junqiu-lei
Copy link
Member Author

@canascar The popover component is come from maplibre instead of OUI which is implemented by @VijayanB, I don't think it can be easily replaced to the OUI component? CC @VijayanB

@kgcreative
Copy link
Member

Yeah, my understanding is we're "sort of" making it look like OUI, but there will be differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x bug Something isn't working v2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants