Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS with more specific code owners #1256

Closed
wants to merge 15 commits into from

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Nov 16, 2023

Description

Coming from #1252, this PR updates codeowners to:

  • Include less owners overall, to get more focused reviews.
  • Adds dedicated owners for the major subcomponents.

Issues Resolved

Closes #1252.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
.github/CODEOWNERS Outdated Show resolved Hide resolved
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.62%. Comparing base (bccdc31) to head (cd87d01).
Report is 19 commits behind head on main.

❗ Current head cd87d01 differs from pull request most recent head 33a9523. Consider uploading reports for the commit 33a9523 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1256      +/-   ##
==========================================
- Coverage   57.61%   56.62%   -0.99%     
==========================================
  Files         368      348      -20     
  Lines       13915    12656    -1259     
  Branches     3650     3202     -448     
==========================================
- Hits         8017     7167     -850     
+ Misses       5835     5436     -399     
+ Partials       63       53      -10     
Flag Coverage Δ
dashboards-observability 56.62% <ø> (-0.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
@ps48
Copy link
Member

ps48 commented Jan 12, 2024

I propose adding the code-owners as below:
Logs explorer: @mengweieric
panels: @pjfitzgibbons
app analytics: @paulstn
notebooks: @ps48
metrics: @kavithacm
trace analytics: @RyanL1997
Integrations: @Swiddis
Datasources: @RyanL1997

Swiddis and others added 2 commits January 12, 2024 10:33
@Swiddis Swiddis changed the title Update CODEOWNERS with integrations sections Update CODEOWNERS with more specific code owners Jan 12, 2024
Copy link
Collaborator

@kavithacm kavithacm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add Ryan as a maintainer before merging this PR?

Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Swiddis can we reach out to @pjfitzgibbons to see if he wants to be moved to emeritus prior to merging?

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
@Swiddis Swiddis requested a review from derek-ho April 30, 2024 17:57
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
@Swiddis Swiddis closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Split CODEOWNERS to better identify actual code owners
5 participants