Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-apply the integrations kibana backend PR #680

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Jul 14, 2023

Description

For some reason, #565 was un-applied while merging. This re-applies it.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Swiddis and others added 2 commits July 14, 2023 14:18
* Merge in kibana backend from osints/dev

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

* Add integration type to .kibana from osints/dev

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

* Re-add license header

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

* Fix integrations type

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

---------

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #680 (a7b4f39) into 2.9 (8c12cba) will increase coverage by 0.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.9     #680      +/-   ##
==========================================
+ Coverage   43.05%   43.52%   +0.46%     
==========================================
  Files         309      313       +4     
  Lines       18384    18614     +230     
  Branches     4450     4487      +37     
==========================================
+ Hits         7915     8101     +186     
- Misses      10427    10471      +44     
  Partials       42       42              
Flag Coverage Δ
dashboards-observability 43.52% <ø> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@Swiddis Swiddis marked this pull request as ready for review July 14, 2023 22:15
@Swiddis Swiddis merged commit bcb7383 into opensearch-project:2.9 Jul 14, 2023
8 checks passed
Swiddis added a commit to Swiddis/dashboards-observability that referenced this pull request Jul 14, 2023
* Merge Kibana backend from osints/dev into main (opensearch-project#565)

* Merge in kibana backend from osints/dev

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

* Add integration type to .kibana from osints/dev

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

* Re-add license header

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

* Fix integrations type

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

---------

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

* Remove extra test files

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

---------

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis added a commit that referenced this pull request Jul 28, 2023
* Merge Kibana backend from osints/dev into main (#565)

* Merge in kibana backend from osints/dev



* Add integration type to .kibana from osints/dev



* Re-add license header



* Fix integrations type



---------



* Remove extra test files



---------

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants