-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #146
Comments
Signed-off-by: Mark Cohen <markcoh@amazon.com>
* updating CODEOWNERS as per issue #146 Signed-off-by: Mark Cohen <markcoh@amazon.com> * corrected comment to point to MAINTAINERS.md Signed-off-by: Mark Cohen <markcoh@amazon.com> * moving .github/.codecov.yml to root Signed-off-by: Mark Cohen <markcoh@amazon.com> * removed .github/.codecov.yml Signed-off-by: Mark Cohen <markcoh@amazon.com> --------- Signed-off-by: Mark Cohen <markcoh@amazon.com>
You have the |
@opensearch-project/admin can you please remove the group search-relevance-dashboards-team and check that the folks listed in CODEOWNERS have the right access to this repo? Thanks! |
@macohen Done! |
I was able to approve and merge #164, so it looks like I'm still a maintainer. Edit: though the approval message there said:
So, maybe it was still relying on the team permissions? I'll keep an eye out on our next PR(s). |
@peternied I don't see the access settings on the repo. |
@opensearch-project/admin I'm not able to see the access settings on this repo as per @peternied. @mingshl, @msfroh can you validate as well, please? |
@macohen I can't see access settings. |
I checked the current access and everything looks good and baselined so closing this issue. |
Reopening since I still do not see the "Manage access" screen that @peternied mentioned. Here's what I see when clicking "Settings." Am I supposed to see only this? How can I add new maintainers otherwise? |
Misunderstood that org admins still must be the ones to grant maintainer roles. It's not the repo owner. |
* updating CODEOWNERS as per issue #146 Signed-off-by: Mark Cohen <markcoh@amazon.com> * corrected comment to point to MAINTAINERS.md Signed-off-by: Mark Cohen <markcoh@amazon.com> * moving .github/.codecov.yml to root Signed-off-by: Mark Cohen <markcoh@amazon.com> * removed .github/.codecov.yml Signed-off-by: Mark Cohen <markcoh@amazon.com> * Adding Louis Chu and Sean Li as maintainers Signed-off-by: Mark Cohen <markcoh@amazon.com> --------- Signed-off-by: Mark Cohen <markcoh@amazon.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@dblock.org>
Verified, thanks. |
Follow opensearch-project/.github#125 to baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions.
Close this issue when:
If this repo's permissions was already baselined, please confirm the above when closing this issue.
The text was updated successfully, but these errors were encountered: