Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #146

Closed
Tracked by #125
dblock opened this issue Feb 14, 2023 · 14 comments · Fixed by #148
Closed
Tracked by #125

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #146

dblock opened this issue Feb 14, 2023 · 14 comments · Fixed by #148
Assignees
Labels
Search Indicates a search feature - useful for cross project searches

Comments

@dblock
Copy link
Member

dblock commented Feb 14, 2023

Follow opensearch-project/.github#125 to baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions.

Close this issue when:

  1. MAINTAINERS.md has the correct list of project maintainers.
  2. CODEOWNERS exists and has the correct list of aliases.
  3. Repo permissions only contain individual aliases as collaborators with maintain rights, admin, and triage teams.
  4. All other teams are removed from repo permissions.

If this repo's permissions was already baselined, please confirm the above when closing this issue.

@macohen macohen self-assigned this Feb 15, 2023
@macohen macohen removed the untriaged label Feb 15, 2023
macohen added a commit to macohen/dashboards-search-relevance that referenced this issue Feb 15, 2023
Signed-off-by: Mark Cohen <markcoh@amazon.com>
noCharger pushed a commit that referenced this issue Feb 20, 2023
* updating CODEOWNERS as per issue #146

Signed-off-by: Mark Cohen <markcoh@amazon.com>

* corrected comment to point to MAINTAINERS.md

Signed-off-by: Mark Cohen <markcoh@amazon.com>

---------

Signed-off-by: Mark Cohen <markcoh@amazon.com>
msfroh pushed a commit that referenced this issue Mar 6, 2023
* updating CODEOWNERS as per issue #146

Signed-off-by: Mark Cohen <markcoh@amazon.com>

* corrected comment to point to MAINTAINERS.md

Signed-off-by: Mark Cohen <markcoh@amazon.com>

* moving .github/.codecov.yml to root

Signed-off-by: Mark Cohen <markcoh@amazon.com>

* removed .github/.codecov.yml

Signed-off-by: Mark Cohen <markcoh@amazon.com>

---------

Signed-off-by: Mark Cohen <markcoh@amazon.com>
@dblock
Copy link
Member Author

dblock commented Mar 9, 2023

You have the search-relevance-dashboards-team with 4 members that has maintain access to this repo. Only folks listed in MAINTAINERS/CODEOWNERS need to have maintain access, and groups don't support external collaborators and therefore should be removed. Please work with an admin to remove the group, and add individuals.

@dblock dblock reopened this Mar 9, 2023
@macohen macohen added Search Indicates a search feature - useful for cross project searches and removed untriaged labels Mar 10, 2023
@macohen
Copy link
Collaborator

macohen commented Mar 16, 2023

@opensearch-project/admin can you please remove the group search-relevance-dashboards-team and check that the folks listed in CODEOWNERS have the right access to this repo?

Thanks!

@peternied
Copy link
Member

@macohen Done!

@macohen
Copy link
Collaborator

macohen commented Mar 16, 2023

@mingshl @msfroh can you verify that all your permissions as maintainers on this repo remain the same?

@macohen macohen assigned mingshl, msfroh and macohen and unassigned macohen and mingshl Mar 16, 2023
@msfroh
Copy link
Collaborator

msfroh commented Mar 16, 2023

I was able to approve and merge #164, so it looks like I'm still a maintainer.

Edit: though the approval message there said:

msfroh approved these changes on behalf of https://github.com/orgs/opensearch-project/teams/search-relevance-dashboards-team

So, maybe it was still relying on the team permissions? I'll keep an eye out on our next PR(s).

@peternied
Copy link
Member

Can you see the access settings on repo? Here is a screen shot - I believe this should be enough verification. Pinging the admin team if there was something surprising would be a good way to deal with lack of access issues.

image

@macohen
Copy link
Collaborator

macohen commented Mar 30, 2023

@peternied I don't see the access settings on the repo.

@macohen
Copy link
Collaborator

macohen commented Apr 6, 2023

@opensearch-project/admin I'm not able to see the access settings on this repo as per @peternied. @mingshl, @msfroh can you validate as well, please?

@msfroh
Copy link
Collaborator

msfroh commented Apr 6, 2023

@macohen I can't see access settings.

@bbarani
Copy link
Member

bbarani commented Apr 6, 2023

@msfroh @macohen Let me help you here.

@bbarani
Copy link
Member

bbarani commented Apr 6, 2023

I checked the current access and everything looks good and baselined so closing this issue.

@bbarani bbarani closed this as completed Apr 6, 2023
@macohen
Copy link
Collaborator

macohen commented Apr 10, 2023

Reopening since I still do not see the "Manage access" screen that @peternied mentioned. Here's what I see when clicking "Settings." Am I supposed to see only this? How can I add new maintainers otherwise?
Screenshot 2023-04-10 at 4 47 39 PM

@macohen
Copy link
Collaborator

macohen commented Apr 13, 2023

Misunderstood that org admins still must be the ones to grant maintainer roles. It's not the repo owner.

@macohen macohen closed this as completed Apr 13, 2023
msfroh pushed a commit that referenced this issue Apr 14, 2023
* updating CODEOWNERS as per issue #146

Signed-off-by: Mark Cohen <markcoh@amazon.com>

* corrected comment to point to MAINTAINERS.md

Signed-off-by: Mark Cohen <markcoh@amazon.com>

* moving .github/.codecov.yml to root

Signed-off-by: Mark Cohen <markcoh@amazon.com>

* removed .github/.codecov.yml

Signed-off-by: Mark Cohen <markcoh@amazon.com>

* Adding Louis Chu and Sean Li as maintainers

Signed-off-by: Mark Cohen <markcoh@amazon.com>

---------

Signed-off-by: Mark Cohen <markcoh@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@dblock.org>
@dblock
Copy link
Member Author

dblock commented Apr 20, 2023

Verified, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Search Indicates a search feature - useful for cross project searches
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants