Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing Confirmation] Confirm current testing requirements #152

Closed
scrawfor99 opened this issue Feb 22, 2023 · 3 comments
Closed

[Testing Confirmation] Confirm current testing requirements #152

scrawfor99 opened this issue Feb 22, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request Search Indicates a search feature - useful for cross project searches

Comments

@scrawfor99
Copy link

scrawfor99 commented Feb 22, 2023

As part of the discussion around implementing an organization-wide testing policy, I am visiting each repo to see what tests they currently perform. I am conducting this work on GitHub so that it is easy to reference.

Looking at the Dashboards Search Relevance repository, it appears there is

Repository Unit Tests Integration Tests Backwards Compatibility Tests Additional Tests Link
Dashboards Search Relevance
  • Certificate or Origin, Changelog Verifier, Lint Checker #152

    I don't see any requirements for code coverage in the testing documentation. If there are any specific requirements could you respond to this issue to let me know?

    If there are any tests I missed or anything you think all repositories in OpenSearch should have for testing please respond to this issue with details.

    @scrawfor99 scrawfor99 added enhancement New feature or request untriaged labels Feb 22, 2023
    @scrawfor99 scrawfor99 changed the title [FEATURE] [Testing Confirmation] Confirm current testing requirements Feb 22, 2023
    @macohen
    Copy link
    Collaborator

    macohen commented Feb 22, 2023

    We have informally said that coverage should not drop below 80%. We also have this .codecov.yml file which may not be working right: https://github.com/opensearch-project/dashboards-search-relevance/blob/main/.github/.codecov.yml.

    @scrawfor99
    Copy link
    Author

    Hi @macohen, thank you for the info, I will update that in the notes for the discussion. I appreciate you taking the time to follow up.

    @macohen macohen removed the untriaged label Feb 27, 2023
    @macohen macohen self-assigned this Feb 27, 2023
    @macohen macohen added the Search Indicates a search feature - useful for cross project searches label Mar 10, 2023
    @macohen
    Copy link
    Collaborator

    macohen commented Apr 11, 2023

    that codecov.yml file is in the right place now. closing this issue.

    @macohen macohen closed this as completed Apr 11, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    enhancement New feature or request Search Indicates a search feature - useful for cross project searches
    Projects
    Status: Done
    Development

    No branches or pull requests

    2 participants