Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide validations of AWS accountIds #4398

Closed
dlvenable opened this issue Apr 8, 2024 · 0 comments · Fixed by #4400
Closed

Provide validations of AWS accountIds #4398

dlvenable opened this issue Apr 8, 2024 · 0 comments · Fixed by #4400
Assignees
@dlvenable
Labels
enhancement New feature or request
Milestone
v2.8

Comments

@dlvenable
Copy link
Member

Is your feature request related to a problem? Please describe.

Users can provide values that are not AWS account Ids in the S3 source.

bucket_owners:
  my-bucket: abc

Describe the solution you'd like

Validate AWS account Ids wherever they are supplied. They should be 12 digits.

Optionally, we can also trim out any spaces and hyphens (even from the middle) in case users provide them in the form of 1234-5678-9012. I've not seen this happen, but the AWS Console shows the account Id in that form.
@dlvenable dlvenable self-assigned this Apr 9, 2024
@dlvenable dlvenable added this to the v2.8 milestone Apr 9, 2024
@dlvenable dlvenable added enhancement New feature or request and removed untriaged labels Apr 9, 2024
dlvenable added a commit to dlvenable/data-prepper that referenced this issue Apr 9, 2024
@dlvenable
Validate the AWS account Id in the S3 source when configuring either …
c2d544a 
…the default_bucket_owner or the bucket_owners map. Implemented this by adding a new bean validation annotation @AwsAccountId in the aws-plugin-api. Resolves opensearch-project#4398

Signed-off-by: David Venable <dlv@amazon.com>
@dlvenable dlvenable mentioned this issue Apr 9, 2024
Merged
4 tasks
dlvenable added a commit that referenced this issue Apr 11, 2024
@dlvenable
Validate the AWS account Id in the S3 source when configuring either …
e05a052 
…the default_bucket_owner or the bucket_owners map. Implemented this by adding a new bean validation annotation @AwsAccountId in the aws-plugin-api. Resolves #4398 (#4400)

Signed-off-by: David Venable <dlv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlvenable dlvenable

Labels
enhancement New feature or request
Projects
Data Prepper Tracking Board
Status: Done
Milestone
v2.8
Development

Successfully merging a pull request may close this issue.

Validate the AWS account Id in the S3 source using a new annotation dlvenable/data-prepper
1 participant
@dlvenable