Github-issue#1048 : s3-sink integration test implementation. #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deepak Sahu <deepak.sahu562@gmail.com>
deepaksahu562
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2624 +/- ##
============================================
+ Coverage 93.56% 93.61% +0.04%
- Complexity 2253 2255 +2
============================================
Files 262 262
Lines 6308 6308
Branches 521 521
============================================
+ Hits 5902 5905 +3
+ Misses 268 266 -2
+ Partials 138 137 -1 |
kkondaka
reviewed
May 3, 2023
| S3SinkService s3SinkService = createObjectUnderTest(); | ||
| s3SinkService.output(setEventQueue()); | ||
| int s3ObjectCountAfterIngest = gets3ObjectCount(); | ||
| assertThat(s3ObjectCountAfterIngest, greaterThan(s3ObjectCountBeforeIngest)); |
Signed-off-by: Deepak Sahu <deepak.sahu562@gmail.com>
dlvenable
requested changes
May 11, 2023
| s3ObjectCount = objects.size(); | ||
| } catch (S3Exception e) { | ||
| LOG.error(e.awsErrorDetails().errorMessage()); | ||
| System.exit(1); |
There was a problem hiding this comment.
This is going to fail the whole test suite and will prevent accurate reporting of failures.
Just let the exception be thrown here. Remove the try-catch block entirely. JUnit will handle it.
There was a problem hiding this comment.
Removed the try-catch block.
| s3SinkService.output(setEventQueue()); | ||
| int s3ObjectCountAfterIngest = gets3ObjectCount(); | ||
| assertThat(s3ObjectCountAfterIngest, equalTo(s3ObjectCountBeforeIngest + 1)); | ||
| } |
There was a problem hiding this comment.
This test should actually load the S3 object and verify the data is correct.
There was a problem hiding this comment.
Resolved.
Added two test-cases.
- verify_flushed_object_count_into_s3_bucket
- verify_flushed_records_into_s3_bucket
Signed-off-by: Deepak Sahu <deepak.sahu562@gmail.com>
deepaksahu562
dismissed stale reviews from ashoktelukuntla and kkondaka
via
24dc6c9
|
@ashoktelukuntla \ @dlvenable |
dlvenable
approved these changes
May 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
GitHub-issue #1048
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.