Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: support gzip compression for armeria sources #2702

Merged
merged 7 commits into from
May 17, 2023

Conversation

chenqi0805
Copy link
Collaborator

Description

This PR supports gzip as compression type in push based sources

  • http
  • otel-trace
  • otel-logs
  • otel-metrics

Issues Resolved

Resolves #1399
Resolves #1176

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: George Chen <qchea@amazon.com>
Signed-off-by: George Chen <qchea@amazon.com>
Signed-off-by: George Chen <qchea@amazon.com>
Signed-off-by: George Chen <qchea@amazon.com>
Signed-off-by: George Chen <qchea@amazon.com>
Signed-off-by: George Chen <qchea@amazon.com>
@github-actions
Copy link

github-actions bot commented May 16, 2023

Unit Test Results

1 000 files  +  2  1 000 suites  +2   30m 51s ⏱️ ±0s
3 790 tests +12  3 790 ✔️ +12  0 💤 ±0  0 ±0 
7 636 runs  +24  7 636 ✔️ +24  0 💤 ±0  0 ±0 

Results for commit a497d35. ± Comparison against base commit a7dce8d.

♻️ This comment has been updated with latest results.

Signed-off-by: George Chen <qchea@amazon.com>
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #2702 (a497d35) into main (71415bb) will increase coverage by 0.16%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2702      +/-   ##
============================================
+ Coverage     93.53%   93.70%   +0.16%     
- Complexity     2219     2288      +69     
============================================
  Files           259      262       +3     
  Lines          6232     6397     +165     
  Branches        511      542      +31     
============================================
+ Hits           5829     5994     +165     
+ Misses          266      265       -1     
- Partials        137      138       +1     

see 7 files with indirect coverage changes

@chenqi0805 chenqi0805 merged commit a540932 into main May 17, 2023
30 checks passed
@chenqi0805 chenqi0805 deleted the enh/support-gzip-compression-for-armeria-sources branch May 17, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support gzip encoded content in http source Support compression in OTel sources (trace, logs, metrics)
3 participants