Add support to tag events when parse_json fails to parse #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
kkondaka
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #2745 +/- ##
============================================
+ Coverage 93.72% 93.90% +0.17%
- Complexity 2280 2286 +6
============================================
Files 264 264
Lines 6389 6394 +5
Branches 528 528
============================================
+ Hits 5988 6004 +16
+ Misses 265 254 -11
Partials 136 136
|
graytaylor0
approved these changes
May 24, 2023
cmanning09
reviewed
May 24, 2023
| @@ -287,6 +288,24 @@ void test_when_condition_skips_processing_when_evaluates_to_false() { | |||
|
|
|||
| } | |||
|
|
|||
| @Test | |||
| void test_tags_when_json_parse_fails() { | |||
There was a problem hiding this comment.
What happens if tags don't exist? Can we add a check to ensure we aren't building tag set will null values?
There was a problem hiding this comment.
@cmanning09 you mean, I should check to make sure tags are null when no failures? Something like assertThat(parsedEvent.getMetadata().getTags(), equalTo(Set.of())); to be added in all other tests?
There was a problem hiding this comment.
Yes that works. Feel free to add this in a follow up PR.
cmanning09
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support to tag events when parse_json fails to parse.
Resolves #2744
Adds
tags_on_failurenew option to parse_json processor. An example, parse_json processor config would beIssues Resolved
Resolves #2744
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.