Adds support for end-to-end acknowledgements in the S3 Sink #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pensearch-project#2732 Signed-off-by: David Venable <dlv@amazon.com>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed and
oeyh
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2755 +/- ##
============================================
+ Coverage 93.81% 93.92% +0.10%
- Complexity 2315 2318 +3
============================================
Files 269 269
Lines 6482 6482
Branches 534 534
============================================
+ Hits 6081 6088 +7
+ Misses 265 256 -9
- Partials 136 138 +2 |
chenqi0805
approved these changes
May 25, 2023
4 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds end-to-end acknowledgements to the S3 sink.
This also fixes a problem with the README.md file.
Issues Resolved
Resolves #2732
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.