Moves the S3 sink bucket configuration to the root configuration #2759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed and
oeyh
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2759 +/- ##
============================================
+ Coverage 94.12% 94.14% +0.01%
+ Complexity 2441 2440 -1
============================================
Files 278 278
Lines 6744 6744
Branches 551 551
============================================
+ Hits 6348 6349 +1
+ Misses 256 254 -2
- Partials 140 141 +1 |
cmanning09
reviewed
May 25, 2023
| @@ -29,8 +29,10 @@ public class S3SinkConfig { | |||
|
|
|||
| @JsonProperty("bucket") | |||
| @NotNull | |||
There was a problem hiding this comment.
Should we add a min validation here to prevent against empty strings?
| void get_bucket_option_test() { | ||
| assertThat(new S3SinkConfig().getBucketOptions(), equalTo(null)); | ||
| void get_bucket_name_test() { | ||
| assertThat(new S3SinkConfig().getBucketName(), equalTo(null)); |
There was a problem hiding this comment.
bucketName has a nonNull validation on it. Let's make this test be more realistic.
| @@ -263,7 +260,7 @@ void test_output_with_uploadedToS3_success_records_byte_count() throws IOExcepti | |||
|
|
|||
| @Test | |||
| void test_output_with_uploadedToS3_failed() throws IOException { | |||
| when(s3SinkConfig.getBucketOptions().getBucketName()).thenReturn(null); | |||
| when(s3SinkConfig.getBucketName()).thenReturn(null); | |||
There was a problem hiding this comment.
Can we use a random string here? We should be using realistic values. Same is true for test_retryFlushToS3_negative
chenqi0805
previously approved these changes
May 26, 2023
cmanning09
previously approved these changes
May 30, 2023
Signed-off-by: David Venable <dlv@amazon.com>
Signed-off-by: David Venable <dlv@amazon.com>
dlvenable
force-pushed
the
s3-sink-top-level-bucket
branch
from
c74df77
to
54ed709
Compare
cmanning09
approved these changes
May 31, 2023
chenqi0805
approved these changes
May 31, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the S3 bucket configurations to simplify the YAML.
New configuration:
Old configuration:
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.