Updates the S3 sink to use the AWS Plugin for loading AWS credentials #2787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Resolves opensearch-project#2767 Signed-off-by: David Venable <dlv@amazon.com>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed and
oeyh
as code owners
…meterize the regions to ensure they are not variable. Signed-off-by: David Venable <dlv@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #2787 +/- ##
============================================
- Coverage 94.12% 93.94% -0.18%
+ Complexity 2441 2437 -4
============================================
Files 278 278
Lines 6744 6759 +15
Branches 551 551
============================================
+ Hits 6348 6350 +2
- Misses 256 269 +13
Partials 140 140 |
cmanning09
reviewed
Jun 1, 2023
Comment on lines
+31
to
+36
| public String getAwsStsRoleArn() { | ||
| return awsStsRoleArn; | ||
| } | ||
|
|
||
| return awsCredentialsProvider; | ||
| public Map<String, String> getAwsStsHeaderOverrides() { | ||
| return awsStsHeaderOverrides; |
There was a problem hiding this comment.
There are no unit tests in AwsAuthenticationOptionsTest.java file for these new methods
There was a problem hiding this comment.
@cmanning09 , I just pushed a change which adds testing for these getters.
…approach to deserialize using Jackson to better simulate the final usage. Signed-off-by: David Venable <dlv@amazon.com>
oeyh
approved these changes
Jun 2, 2023
cmanning09
approved these changes
Jun 2, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the
s3sink to use the AWS Plugin. This now provides the AWS credentials for this sink. This includes some related refactoring including fixing a bug where the S3 client was created anew for every object write.Issues Resolved
Resolves #2767
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.