Fixes a bug in the S3 sink where events without handles throw NPE #2814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NPEs by skipping any such handles. Signed-off-by: David Venable <dlv@amazon.com>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed and
oeyh
as code owners
cmanning09
reviewed
Jun 5, 2023
| @@ -106,7 +106,9 @@ void output(Collection<Record<Event>> records) { | |||
| final byte[] encodedBytes = encodedEvent.getBytes(); | |||
|
|
|||
| currentBuffer.writeEvent(encodedBytes); | |||
| bufferedEventHandles.add(event.getEventHandle()); | |||
There was a problem hiding this comment.
Should we add a unit test to confirm this is fixed? And help prevent future NPEs around this leak into this plugin?
There was a problem hiding this comment.
I actually tried this, but I was not able to get it to crash such that the test would actually show any verification.
There was a problem hiding this comment.
Null event handle would be the default case when not using end-to-end acknowledgements.
There was a problem hiding this comment.
@cmanning09 , I found that there was an unnecessary try-catch on NullPointerException. I removed that and was able to add a valid test.
…rupt the thread on exceptions. Signed-off-by: David Venable <dlv@amazon.com>
kkondaka
approved these changes
Jun 5, 2023
chenqi0805
approved these changes
Jun 5, 2023
Closed
MaGonzalMayedo
pushed a commit
to MaGonzalMayedo/data-prepper
that referenced
this pull request
Jun 21, 2023
…ensearch-project#2814) Fixes a bug in the S3 sink where events without handles are throwing NPEs by skipping any such handles. Signed-off-by: David Venable <dlv@amazon.com> Signed-off-by: Marcos_Gonzalez_Mayedo <alemayed@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the
s3sink for null Event handles.Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.