Adds sigv4 support to Elasticsearch client #3305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
dlvenable
reviewed
Sep 5, 2023
| * An {@link HttpRequestInterceptor} that signs requests using any AWS {@link Signer} | ||
| * and {@link AwsCredentialsProvider}. | ||
| */ | ||
| final class AwsRequestSigningApacheInterceptor implements HttpRequestInterceptor { |
There was a problem hiding this comment.
I think we were moving this into the aws-plugin-api project to re-use. Perhaps that PR hasn't yet been merged.
There was a problem hiding this comment.
I will make it a public class in aws-plugin-api
dlvenable
requested changes
Sep 6, 2023
| @@ -12,7 +13,7 @@ jacocoTestCoverageVerification { | |||
| violationRules { | |||
| rule { | |||
| limit { | |||
| minimum = 1.0 | |||
| minimum = 0.95 | |||
There was a problem hiding this comment.
It would be very good to keep 100% coverage. Is there a certain line you are having difficulty reaching?
There was a problem hiding this comment.
There was a problem hiding this comment.
Because I can't mock the response of context.getAttribute to return an invalid HttpHost, and I can't mock it to throw either since that's a checked exception
Signed-off-by: Taylor Gray <tylgry@amazon.com>
…source and sink Signed-off-by: Taylor Gray <tylgry@amazon.com>
Signed-off-by: Taylor Gray <tylgry@amazon.com>
Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
force-pushed
the
Sigv4ForEsClient
branch
from
2c60a8e
to
5294eb3
Compare
engechas
approved these changes
Sep 6, 2023
dlvenable
approved these changes
Sep 6, 2023
asifsmohammed
pushed a commit
to asifsmohammed/data-prepper
that referenced
this pull request
Sep 27, 2023
Adds sigv4 support to Elasticsearch client. Move AwsRequestSigningApacheInterceptor to aws-plugin-api, use in os source and sink Signed-off-by: Taylor Gray <tylgry@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was a miss from earlier on. The Elasticsearch client currently only supports username and password, and this adds sigv4 support so elasticsearch clusters will be able to alternatively specify an
sts_role_arnIssues Resolved
Related to #1985
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.