Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow . and @ characters to be part of json pointer in expressions #4130

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

kkondaka
Copy link
Collaborator

@kkondaka kkondaka commented Feb 14, 2024

Description

Allow . and @ characters to be part of json pointer in expressions.

Allows expressions with json pointers containing "." and "@". For example

/part1.part2@part3 == "xyz"

Issues Resolved

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • [X ] New functionality includes testing.
  • [ X] New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • [X ] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@kkondaka kkondaka merged commit 9d1ae74 into opensearch-project:main Feb 15, 2024
47 checks passed
@dlvenable dlvenable added this to the v2.7 milestone Feb 15, 2024
@kkondaka kkondaka deleted the expressions-enhancement branch May 13, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants