Add new OTEL Metrics source that creates events #4183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
asifsmohammed,
dlvenable and
oeyh
as code owners
…ew events are created in the source Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
engechas
previously approved these changes
Feb 24, 2024
Comment on lines
102
to
103
| final int bufferWriteTimeoutInMillis = | ||
| (int) (oTelMetricsSourceConfig.getRequestTimeoutInMillis() * 0.8); |
There was a problem hiding this comment.
Doesn't look like this is used anywhere
| Collection<Record<? extends Metric>> metrics; | ||
| AtomicInteger droppedCounter = new AtomicInteger(0); | ||
|
|
||
| OTelProtoCodec.OTelProtoDecoder oTelProtoDecoder = new OTelProtoCodec.OTelProtoDecoder(); |
There was a problem hiding this comment.
It looks like the decoder is passed through the constructor in the other sources. We could do the same in this class to avoid instantiating a new one for each request: https://github.com/opensearch-project/data-prepper/blob/main/data-prepper-plugins/otel-trace-source/src/main/java/org/opensearch/dataprepper/plugins/source/oteltrace/OTelTraceGrpcService.java#L57
| @@ -81,7 +78,12 @@ private void processRequest(final ExportMetricsServiceRequest request, final Str | |||
| if (buffer.isByteBuffer()) { | |||
| buffer.writeBytes(request.toByteArray(), null, bufferWriteTimeoutInMillis); | |||
| } else { | |||
| buffer.write(new Record<>(request), bufferWriteTimeoutInMillis); | |||
| Collection<Record<? extends Metric>> metrics; | |||
| AtomicInteger droppedCounter = new AtomicInteger(0); | |||
There was a problem hiding this comment.
Should we be emitting a metric for this or does the decoder already handle that?
graytaylor0
previously approved these changes
Feb 24, 2024
| @@ -935,12 +942,13 @@ void gRPC_with_auth_request_writes_to_buffer_with_successful_response() throws E | |||
| final ExportMetricsServiceResponse exportResponse = client.export(createExportMetricsRequest()); | |||
| assertThat(exportResponse, notNullValue()); | |||
|
|
|||
| final ArgumentCaptor<Record<ExportMetricsServiceRequest>> bufferWriteArgumentCaptor = ArgumentCaptor.forClass(Record.class); | |||
| verify(buffer).write(bufferWriteArgumentCaptor.capture(), anyInt()); | |||
| //final ArgumentCaptor<Record<ExportMetricsServiceRequest>> bufferWriteArgumentCaptor = ArgumentCaptor.forClass(Record.class); | |||
| @@ -40,7 +46,7 @@ public class OTelMetricsGrpcService extends MetricsServiceGrpc.MetricsServiceImp | |||
|
|
|||
|
|
|||
| public OTelMetricsGrpcService(int bufferWriteTimeoutInMillis, | |||
| Buffer<Record<ExportMetricsServiceRequest>> buffer, | |||
There was a problem hiding this comment.
Please be sure to verify that the original source that uses ExportMetricsServiceRequest is not affected by this change
There was a problem hiding this comment.
Original source is not there any more. We are replacing original source with this new behavior.
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
graytaylor0
previously approved these changes
Feb 24, 2024
engechas
previously approved these changes
Feb 25, 2024
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
graytaylor0
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new OTEL Metrics source that creates events
Added a new OTEL source that creates DataPrepper Events before putting them into buffer.
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.