Modify S3 Source to create multiple SqsWorkers #4239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
asifsmohammed,
dlvenable and
oeyh
as code owners
dlvenable
requested changes
Mar 5, 2024
| @@ -43,6 +44,10 @@ public class S3SourceConfig { | |||
| @Valid | |||
| private SqsOptions sqsOptions; | |||
|
|
|||
| @JsonProperty("workers") | |||
| @Valid | |||
| private int numWorkers = DEFAULT_NUMBER_OF_WORKERS; | |||
There was a problem hiding this comment.
Please add an @Min(1) on this.
We should probably also have some sort of upper bound to prevent excessive values. Perhaps: @Max(1000).
| @@ -24,6 +24,7 @@ | |||
|
|
|||
| public class S3SourceConfig { | |||
| static final Duration DEFAULT_BUFFER_TIMEOUT = Duration.ofSeconds(10); | |||
| static final Duration DEFAULT_NUMBER_OF_WORKERS = 5; | |||
There was a problem hiding this comment.
I think we should leave this as 1 so that this change does not impact existing pipelines. I believe with large object sizes 1 is the ideal value also.
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
dlvenable
approved these changes
Mar 6, 2024
graytaylor0
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify S3 Source to create multiple SqsWorkers to process SQS messages in parallel.
Provided configuration option to change the number of workers.
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.