GeoIP performance: database expiration and InetAddress optimization #4286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From performance testing of the
geoip
processor I found two unrelated areas of unnecessary performance slowdowns.Database expiration
The
geoip
processor was check if the database was expired for each event in a batch. This is a surprisingly slow operation becauseInstant.now()
callsVM.getNanoTimeAdjustment(localOffset)
which is somewhat slow.This PR helps by adding a
BatchGeoIPDatabaseReader
which holds the value ofisExpired
for the whole batch. We don't re-evaluate for each event.InetAddress optimization
Parsing the IP address is somewhat slow. The
geoip
processor was doing this twice. I consolidated this work into a single methodGeoInetAddress::usableInetFromString
which parses the string and then returns a non-emptyOptional<InetAddress>
if this IP address is usable (currently if it is public or not). Some of the refactoring here is also to make it more generic.Finally, I moved the main processing into its own method to help with readability.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.