Provide a config option to do node local aggregation #4306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
asifsmohammed,
dlvenable and
oeyh
as code owners
graytaylor0
previously approved these changes
Mar 20, 2024
dlvenable
reviewed
Mar 20, 2024
| @@ -28,6 +28,10 @@ public class AggregateProcessorConfig { | |||
| @NotNull | |||
| private PluginModel aggregateAction; | |||
|
|
|||
| @JsonProperty("local_only") | |||
There was a problem hiding this comment.
What do you think about naming this local_aggregations_only? It may make clear what is local only.
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
graytaylor0
approved these changes
Mar 20, 2024
dlvenable
requested changes
Mar 20, 2024
| @@ -51,6 +51,9 @@ While not necessary, a great way to set up the Aggregate Processor [identificati | |||
| ### <a name="when"></a> | |||
| * `when` (Optional): A `String` that represents a condition that must be evaluated to true for the aggregation to be applied on the event. Events that do not evaluate to true on the condition are skipped. Default is no condition which means all events are included in the aggregation. | |||
|
|
|||
| ### <a name="local_only"></a> | |||
| * `local_only` (Optional): A `Boolean` indicating if the aggregation should be done local to node instead of forwarding to remote peers. | |||
There was a problem hiding this comment.
Please also update this line.
dlvenable
approved these changes
Mar 20, 2024
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a config option to do node local aggregation
Added new
local_onlyconfig option toaggregateprocessor to do local aggregation. No events are forwarded to remote peers when this option is used.Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.