Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #2878

Closed
Tracked by #125
dblock opened this issue Feb 14, 2023 · 8 comments · Fixed by #3641
Closed
Tracked by #125

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #2878

dblock opened this issue Feb 14, 2023 · 8 comments · Fixed by #3641
Assignees
@Naarcha-AWS
Labels
1 - Backlog Issue: The issue is unassigned or assigned but not started Sev2 High-medium priority. Upcoming release or incorrect information.

Comments

@dblock
Copy link
Member

dblock commented Feb 14, 2023

Follow opensearch-project/.github#125 to baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions.

Close this issue when:

  1. MAINTAINERS.md has the correct list of project maintainers.
  2. CODEOWNERS exists and has the correct list of aliases.
  3. Repo permissions only contain individual aliases as collaborators with maintain rights, admin, and triage teams.
  4. All other teams are removed from repo permissions.

If this repo's permissions was already baselined, please confirm the above when closing this issue.
@dblock dblock mentioned this issue Feb 14, 2023
Closed
87 tasks
@Naarcha-AWS Naarcha-AWS self-assigned this Feb 20, 2023
@Naarcha-AWS Naarcha-AWS added 1 - Backlog Issue: The issue is unassigned or assigned but not started and removed untriaged labels Feb 20, 2023
@hdhalter hdhalter added the Sev2 High-medium priority. Upcoming release or incorrect information. label Feb 24, 2023
@hdhalter
Copy link
Collaborator

The current https://github.com/opensearch-project/documentation-website/blob/main/MAINTAINERS.md file is correct, but we need to add a couple new maintainers.

@hdhalter
Copy link
Collaborator

@dblock - where is the CODEOWNERS list stored?

@Naarcha-AWS
Copy link
Collaborator

I know where Codeowners should be, I'll add it.

@Naarcha-AWS Naarcha-AWS mentioned this issue Mar 30, 2023
Merged
1 task
Naarcha-AWS added a commit that referenced this issue Mar 30, 2023
@Naarcha-AWS
Update MAINTAINERS.md
5f67732 
Fixes #2878
@Naarcha-AWS Naarcha-AWS mentioned this issue Mar 30, 2023
Merged
1 task
ananzh added a commit to ananzh/documentation-website that referenced this issue Apr 5, 2023
@ananzh
Update CODEOWNERS
af0c5c8 
Issue Resolve
opensearch-project#2878

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Naarcha-AWS added a commit that referenced this issue Apr 6, 2023
@Naarcha-AWS
Update MAINTAINERS.md (#3641)
092baa1 
Fixes #2878
@dblock
Copy link
Member Author

dblock commented Apr 13, 2023

Screenshot 2023-04-13 at 11 04 45 AM

Repo permissions are incorrect.

  • only admin team should have admin
  • individuals in MAINTAINERS should have maintain access directly
  • remove the docs team

Please work with @bbarani's team on adjusting these.

@dblock dblock reopened this Apr 13, 2023
ananzh added a commit to ananzh/documentation-website that referenced this issue Apr 20, 2023
@ananzh
Update CODEOWNER to match maintainer
b639585 
Based on requirement here:
opensearch-project/.github#125

CODEOWNER should include a subset or all maintainers.

Issue Resolve
opensearch-project#2878

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh mentioned this issue Apr 20, 2023
Merged
1 task
ananzh added a commit to ananzh/documentation-website that referenced this issue Apr 20, 2023
@ananzh
Update CODEOWNER to match maintainer
07543ae 
Based on requirement here:
opensearch-project/.github#125

CODEOWNER should include a subset or all maintainers.
Based on the request, update maintainers.

Issue Resolve
opensearch-project#2878

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/documentation-website that referenced this issue Apr 20, 2023
@ananzh
Update Maintainer.md to match CODEOWNER
4625f83 
Based on requirement here:
opensearch-project/.github#125

CODEOWNER should include a subset or all maintainers.
Based on the request, update maintainers.

Issue Resolve
opensearch-project#2878

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@gaiksaya
Copy link
Member

Permissions are updated now:

image

Just wanted to bring this up that codeowners file even though valid will only add the last person as reviewer always. Not sure what the bug is you might want to add it this one https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/.github/CODEOWNERS
cc: @ananzh @Naarcha-AWS

ananzh added a commit to ananzh/documentation-website that referenced this issue Apr 20, 2023
@ananzh
Update CODEOWNER format
a3d4009 
Update format to match other repos. Otherwise
it only add the last reviewer always.

Issue Resolve
opensearch-project#2878

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh mentioned this issue Apr 20, 2023
Merged
1 task
@dblock
Copy link
Member Author

dblock commented Apr 24, 2023

Verified, thx.

ananzh added a commit to ananzh/documentation-website that referenced this issue Apr 24, 2023
@ananzh
Update baseline maintainer and CODEOWNER format
477b6e9 
Update baseline maintainer to include repo owners.
Update format to match other repos. Otherwise
it only add the last reviewer always.

Issue Resolve
opensearch-project#2878

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Naarcha-AWS pushed a commit that referenced this issue Apr 24, 2023
@ananzh
Update baseline maintainer and CODEOWNER format (#3832)
529e275 
Update baseline maintainer to include repo owners.
Update format to match other repos. Otherwise
it only add the last reviewer always.

Issue Resolve
#2878

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@rishabh6788
Copy link

Updated Permissions.
Screen Shot 2023-04-24 at 12 52 17 PM
Screen Shot 2023-04-24 at 12 52 27 PM

@ananzh
Copy link
Member

ananzh commented Apr 24, 2023

thank you @rishabh6788

vagimeli pushed a commit that referenced this issue Apr 25, 2023
@Naarcha-AWS @vagimeli
Update MAINTAINERS.md (#3641)
2f38e51 
Fixes #2878
vagimeli pushed a commit that referenced this issue Apr 25, 2023
@ananzh @vagimeli
Update Maintainer.md to match CODEOWNER (#3831)
f5ba385 
Based on requirement here:
opensearch-project/.github#125

CODEOWNER should include a subset or all maintainers.
Based on the request, update maintainers.

Issue Resolve
#2878

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
vagimeli pushed a commit that referenced this issue Apr 25, 2023
@ananzh @vagimeli
Update baseline maintainer and CODEOWNER format (#3832)
124901e 
Update baseline maintainer to include repo owners.
Update format to match other repos. Otherwise
it only add the last reviewer always.

Issue Resolve
#2878

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
vagimeli pushed a commit that referenced this issue May 4, 2023
@Naarcha-AWS @vagimeli
Update MAINTAINERS.md (#3641)
979e2dd 
Fixes #2878
vagimeli pushed a commit that referenced this issue May 4, 2023
@ananzh @vagimeli
Update Maintainer.md to match CODEOWNER (#3831)
ed6463f 
Based on requirement here:
opensearch-project/.github#125

CODEOWNER should include a subset or all maintainers.
Based on the request, update maintainers.

Issue Resolve
#2878

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
vagimeli pushed a commit that referenced this issue May 4, 2023
@ananzh @vagimeli
Update baseline maintainer and CODEOWNER format (#3832)
5469c23 
Update baseline maintainer to include repo owners.
Update format to match other repos. Otherwise
it only add the last reviewer always.

Issue Resolve
#2878

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this issue Oct 31, 2023
@Naarcha-AWS @harshavamsi
Update MAINTAINERS.md (opensearch-project#3641)
6a33285 
Fixes opensearch-project#2878
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this issue Oct 31, 2023
@ananzh @harshavamsi
Update Maintainer.md to match CODEOWNER (opensearch-project#3831)
cadd125 
Based on requirement here:
opensearch-project/.github#125

CODEOWNER should include a subset or all maintainers.
Based on the request, update maintainers.

Issue Resolve
opensearch-project#2878

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this issue Oct 31, 2023
@ananzh @harshavamsi
Update baseline maintainer and CODEOWNER format (opensearch-project#3832
d8008ea 
)

Update baseline maintainer to include repo owners.
Update format to match other repos. Otherwise
it only add the last reviewer always.

Issue Resolve
opensearch-project#2878

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Naarcha-AWS Naarcha-AWS

Labels
1 - Backlog Issue: The issue is unassigned or assigned but not started Sev2 High-medium priority. Upcoming release or incorrect information.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update MAINTAINERS.md opensearch-project/documentation-website
6 participants
@dblock @rishabh6788 @gaiksaya @ananzh @Naarcha-AWS @hdhalter