Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapshot documentation with storage_type option #1749

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Conversation

ariamarble
Copy link
Contributor

Signed-off-by: ariamarble armarble@amazon.com

Description

New option update

Issues Resolved

#1684

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: ariamarble <armarble@amazon.com>
@ariamarble ariamarble added 4 - Doc Review PR: Doc review in progress v2.4.0 'Issues and PRs related to version v2.4.0' snapshots labels Oct 27, 2022
@ariamarble ariamarble added this to the v2.4 milestone Oct 27, 2022
@ariamarble ariamarble self-assigned this Oct 27, 2022
@ariamarble ariamarble requested a review from a team as a code owner October 27, 2022 19:24
_opensearch/snapshots/snapshot-restore.md Outdated Show resolved Hide resolved
Signed-off-by: ariamarble <armarble@amazon.com>
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ariamarble ariamarble removed the 4 - Doc Review PR: Doc review in progress label Oct 27, 2022
@ariamarble ariamarble merged commit 4f783a6 into main Oct 27, 2022
Copy link
Member

@andrross andrross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature will be experimental in 2.4, similar to segment replication.

We'll want the same caveats here, as well as instructions for enabling the feature flag. I don't know if it's right to have this parameter added to the main documentation for snapshot restore while it is experimental, given the hoops a user has to jump through to enable it.

@@ -343,6 +343,7 @@ Setting | Description
`rename_replacement` | If you want to rename indices as you restore them, use this option to specify the replacement pattern. Use `$0` to include the entire matching index name, `$1` to include the content of the first capture group, etc.
`index_settings` | If you want to change index settings on restore, specify them here.
`ignore_index_settings` | Rather than explicitly specifying new settings with `index_settings`, you can ignore certain index settings in the snapshot and use the cluster defaults on restore.
`storage_type` | `local` indicates that all snapshot metadata and index data will be downloaded to local storage. <br /><br > `remote_snapshot` indicates that snapshot metadata will be downloaded to the cluster, but the remote repository will remain the authoritative store of the index data. Data will be downloaded and cached as necessary to service queries. At least one node in the cluster must be configured with the [search role]({{site.url}}{{site.baseurl}}/security-plugin/access-control/users-roles/) in order to restore a snapshot using the type `remote_snapshot`. <br /><br > Defaults to `local`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roles in the security plugin are a different concept. The only existing documentation I've found for configuring the node roles is in the ML plugin. I haven't found any documentation around the built-in node roles (cluster_manager, data, ingest, etc) that would be appropriate to link here.

@Naarcha-AWS Naarcha-AWS deleted the issue1684 branch December 13, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
snapshots v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants