Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] [v2.4.0] Update documentation for Searchable Snapshot Feature #1795

Merged
merged 4 commits into from
Nov 4, 2022
Merged

[DOC] [v2.4.0] Update documentation for Searchable Snapshot Feature #1795

merged 4 commits into from
Nov 4, 2022

Conversation

ariamarble
Copy link
Contributor

Signed-off-by: ariamarble armarble@amazon.com

Description

Correct and clarify documentation on this feature

Issues Resolved

#1684

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ariamarble
Update documentation for Searchable Snapshot Feature
a5a21ab 
Signed-off-by: ariamarble <armarble@amazon.com>
@ariamarble ariamarble requested a review from a team as a code owner November 2, 2022 19:20
@ariamarble ariamarble marked this pull request as draft November 2, 2022 19:20
@ariamarble ariamarble self-assigned this Nov 2, 2022
@ariamarble ariamarble added v2.4.0 'Issues and PRs related to version v2.4.0' 2 - In progress Issue/PR: The issue or PR is in progress. snapshots labels Nov 2, 2022
@ariamarble ariamarble mentioned this pull request Nov 2, 2022
Closed
4 tasks
@ariamarble
tons of updates
614d0af 
Signed-off-by: ariamarble <armarble@amazon.com>
@ariamarble
minor change to return page to default
fcd38b5 
Signed-off-by: ariamarble <armarble@amazon.com>
@ariamarble ariamarble added 3 - Tech Review PR: Tech review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Nov 2, 2022
@ariamarble ariamarble marked this pull request as ready for review November 2, 2022 23:55
@ariamarble
Copy link
Contributor Author

@andrross and @satnandi would you mind taking a quick look at this one?

@ariamarble ariamarble added 4 - Doc Review PR: Doc review in progress and removed 3 - Tech Review PR: Tech review in progress labels Nov 3, 2022
Naarcha-AWS
Naarcha-AWS reviewed Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@Naarcha-AWS Naarcha-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things.

_opensearch/snapshots/searchable_snapshot.md Outdated Show resolved Hide resolved
_opensearch/snapshots/searchable_snapshot.md Outdated Show resolved Hide resolved
_opensearch/snapshots/searchable_snapshot.md Outdated Show resolved Hide resolved
@nandi-github
Copy link

Looks fine to me.

nandi-github
nandi-github reviewed Nov 3, 2022
View reviewed changes
Copy link

@nandi-github nandi-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine with the new changes.

@ariamarble
made suggested changes
e12ea5a 
Signed-off-by: ariamarble <armarble@amazon.com>
@ariamarble ariamarble changed the title Update documentation for Searchable Snapshot Feature [DOC] [v2.4.0] Update documentation for Searchable Snapshot Feature Nov 4, 2022
alicejw1
alicejw1 approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@alicejw1 alicejw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ariamarble ariamarble added 5 - Final Editorial Review PR: Editorial Review in progress and removed 4 - Doc Review PR: Doc review in progress labels Nov 4, 2022
@carolxob carolxob merged commit f03cad5 into main Nov 4, 2022
natebower
natebower reviewed Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariamarble Please see my comments and let me know if you have any questions. Thanks!

_opensearch/snapshots/searchable_snapshot.md Show resolved Hide resolved
_opensearch/snapshots/searchable_snapshot.md Show resolved Hide resolved
_opensearch/snapshots/searchable_snapshot.md Show resolved Hide resolved
_opensearch/snapshots/searchable_snapshot.md Show resolved Hide resolved
_opensearch/snapshots/searchable_snapshot.md Show resolved Hide resolved
_opensearch/snapshots/searchable_snapshot.md Show resolved Hide resolved
_opensearch/snapshots/searchable_snapshot.md Show resolved Hide resolved
_opensearch/snapshots/searchable_snapshot.md Show resolved Hide resolved
_opensearch/snapshots/searchable_snapshot.md Show resolved Hide resolved
_opensearch/snapshots/searchable_snapshot.md Show resolved Hide resolved
@natebower natebower removed the 5 - Final Editorial Review PR: Editorial Review in progress label Nov 7, 2022
@Naarcha-AWS Naarcha-AWS deleted the issue1684r branch December 13, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross left review comments

@anasalkouz anasalkouz anasalkouz left review comments

@nandi-github nandi-github nandi-github left review comments

@Naarcha-AWS Naarcha-AWS Naarcha-AWS left review comments

@natebower natebower natebower left review comments

@alicejw1 alicejw1 alicejw1 approved these changes

@carolxob carolxob carolxob approved these changes

Assignees

@ariamarble ariamarble

Labels
snapshots v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ariamarble @nandi-github @andrross @anasalkouz @alicejw1 @Naarcha-AWS @natebower @carolxob