Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Security Analytics plugin #1824

Merged
merged 41 commits into from
Nov 18, 2022
Merged

Conversation

cwillum
Copy link
Contributor

@cwillum cwillum commented Nov 6, 2022

Signed-off-by: cwillum cwmmoore@amazon.com

Description

Adds new documentation for Security Analytics.

Issues Resolved

New documentation for the new plugin Security Analytics

Documentation issue #939.

Security analytics MVP overview at GitHub: MVP #7.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum cwillum added 2 - In progress Issue/PR: The issue or PR is in progress. v2.4.0 'Issues and PRs related to version v2.4.0' labels Nov 6, 2022
@cwillum cwillum requested a review from a team as a code owner November 6, 2022 00:50
@cwillum cwillum self-assigned this Nov 6, 2022
@cwillum cwillum marked this pull request as draft November 6, 2022 00:51
cwillum and others added 8 commits November 6, 2022 10:03
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
@Naarcha-AWS
Copy link
Collaborator

Related to issue #939

Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Copy link
Collaborator

@Naarcha-AWS Naarcha-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config syntax needs to match the directory name. Fix that, and you'll be able to see your TOC.

_config.yml Outdated
@@ -40,6 +40,9 @@ collections:
security-plugin:
permalink: /:collection/:path/
output: true
security-analytics-plugin:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
security-analytics-plugin:
security-analytics:

_config.yml Outdated
@@ -91,6 +94,9 @@ just_the_docs:
security-plugin:
name: Security plugin
nav_fold: true
security-analytics-plugin:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
security-analytics-plugin:
security-analytics:

@Naarcha-AWS Naarcha-AWS self-requested a review November 9, 2022 20:56
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum cwillum removed the 2 - In progress Issue/PR: The issue or PR is in progress. label Nov 15, 2022
@cwillum cwillum marked this pull request as ready for review November 15, 2022 16:15
Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum
Copy link
Contributor Author

cwillum commented Nov 15, 2022

@here This PR has not been through technical review. Therefore, we will hold it back from the 2.4 release. Once all of the appropriate reviews have been taken care of, we can backport to 2.4.

@cwillum cwillum added the Needs SME Waiting on input from subject matter expert label Nov 15, 2022
@cwillum cwillum added 2 - In progress Issue/PR: The issue or PR is in progress. 4 - Doc review PR: Doc review in progress labels Nov 17, 2022
@hdhalter hdhalter added 3 - Tech review PR: Tech review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Nov 17, 2022
Copy link
Collaborator

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I haven't finished reviewing yet, but I'll get back to this later.

_security-analytics/index.md Outdated Show resolved Hide resolved
_security-analytics/index.md Outdated Show resolved Hide resolved
_security-analytics/index.md Outdated Show resolved Hide resolved
_security-analytics/index.md Outdated Show resolved Hide resolved
_security-analytics/index.md Outdated Show resolved Hide resolved
_security-analytics/usage/findings.md Outdated Show resolved Hide resolved
_security-analytics/usage/rules.md Outdated Show resolved Hide resolved
_security-analytics/usage/rules.md Outdated Show resolved Hide resolved
_security-analytics/usage/rules.md Outdated Show resolved Hide resolved
_security-analytics/usage/alerts.md Outdated Show resolved Hide resolved
sbcd90 and others added 2 commits November 17, 2022 12:58
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
Copy link
Collaborator

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwillum Please see my edits and comments. Let me know if any clarifications are needed.

_security-analytics/api-tools/alert-finding-api.md Outdated Show resolved Hide resolved
_security-analytics/api-tools/index.md Outdated Show resolved Hide resolved
_security-analytics/api-tools/mappings-api.md Outdated Show resolved Hide resolved
_security-analytics/api-tools/mappings-api.md Outdated Show resolved Hide resolved
_security-analytics/api-tools/mappings-api.md Outdated Show resolved Hide resolved
_security-analytics/usage/rules.md Outdated Show resolved Hide resolved
_security-analytics/usage/rules.md Outdated Show resolved Hide resolved
_security-analytics/usage/rules.md Outdated Show resolved Hide resolved
_security-analytics/usage/rules.md Outdated Show resolved Hide resolved
_security-analytics/usage/rules.md Outdated Show resolved Hide resolved
Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum cwillum merged commit 605edd5 into main Nov 18, 2022
@cwillum cwillum added the backport 2.4 PR: Backport label for 2.4 label Nov 18, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 18, 2022
* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* Delete admin-api.md

* Delete api-index.md

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics (#1901)

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Co-authored-by: Subhobrata Dey <sbcd90@gmail.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
(cherry picked from commit 605edd5)
Naarcha-AWS pushed a commit that referenced this pull request Nov 18, 2022
* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* Delete admin-api.md

* Delete api-index.md

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics (#1901)

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#939-sec-analytics

Signed-off-by: cwillum <cwmmoore@amazon.com>

Signed-off-by: cwillum <cwmmoore@amazon.com>
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Co-authored-by: Subhobrata Dey <sbcd90@gmail.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
(cherry picked from commit 605edd5)

Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
@Naarcha-AWS Naarcha-AWS deleted the fix#939-sec-analytics branch December 13, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Tech review PR: Tech review in progress 4 - Doc review PR: Doc review in progress backport 2.4 PR: Backport label for 2.4 Needs SME Waiting on input from subject matter expert v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants