Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Rules documentation that covers YAML Editor view #2407

Merged
merged 3 commits into from
Jan 14, 2023

Conversation

cwillum
Copy link
Contributor

@cwillum cwillum commented Jan 13, 2023

Signed-off-by: cwillum cwmmoore@amazon.com

Description

A new YAML Editor view has been added for 2.5 on the Rules page for Security Analytics.

Issues Resolved

Added new content and added or updated screenshots to include the new feature.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum cwillum requested a review from a team as a code owner January 13, 2023 21:46
@cwillum cwillum self-assigned this Jan 13, 2023
@cwillum cwillum added 3 - Tech review PR: Tech review in progress 4 - Doc review PR: Doc review in progress v2.5.0 'Issues and PRs related to version v2.5.0' labels Jan 13, 2023
@cwillum cwillum added this to the v2.5.x milestone Jan 13, 2023
@hdhalter hdhalter added the release-notes PR: Include this PR in the automated release notes label Jan 13, 2023
@cwillum cwillum removed the 4 - Doc review PR: Doc review in progress label Jan 13, 2023
@cwillum
Copy link
Contributor Author

cwillum commented Jan 13, 2023

Waiting a while longer for Doc Review to see if I can get a Tech Review first today.

@@ -17,7 +17,27 @@ When you open the Rules page, all rules are listed in the table. Use the search
Alternatively, you can use the **Rule type**, **Rule severity**, and **Source** dropdown menus to drill down in the list of alerts and filter for preferred results. You can use all three menus in combination to narrow results. Select only one option per menu.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Select only one option per menu.

I must have missed this during my initial read of the documentation. The filter menus for this table support selecting multiple options (e.g., the table can be filtered to display only Critical, and Low severity rules).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operator error. Yes, pick as many as you'd like. Thanks. Reworded this statement.


If you choose to create the rule manually, you can refer to Sigma's [Rule Creation Guide](https://github.com/SigmaHQ/sigma/wiki/Rule-Creation-Guide) to help understand details for each field.
* By default, the Visual Editor is displayed. Enter the appropriate content in each field and select **Create** in the lower-right corner of the window to save the rule.
* the Create a rule window also provides the YAML Editor so that you can create the rule directly in a YAML file format. Select **YAML Editor** and then enter information for the pre-populated field types.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo: Should this bullet point start capital T?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Thank you.

Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum cwillum added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Jan 13, 2023
Copy link
Contributor

@carolxob carolxob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@AWSHurneyt AWSHurneyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I forwarded this PR to the rest of the security analytics team in case they have any feedback.

Copy link
Collaborator

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimal comments; LGTM

_security-analytics/usage/rules.md Show resolved Hide resolved
_security-analytics/usage/rules.md Outdated Show resolved Hide resolved
_security-analytics/usage/rules.md Show resolved Hide resolved
* By default, the Visual Editor is displayed. Enter the appropriate content in each field and select **Create** in the lower-right corner of the window to save the rule.
* The Create a rule window also provides the YAML Editor so that you can create the rule directly in a YAML file format. Select **YAML Editor** and then enter information for the pre-populated field types.

The alternatives to manually creating a rule, however, make the process easier and faster. They involve either importing a rule in a YAML file or duplicating an existing rule and customizing it. See the next two sections for detailed steps.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the style guide, we should avoid terms like "easier" Suggestion: "..., however, simplify and speed up the process."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

_security-analytics/usage/rules.md Show resolved Hide resolved
_security-analytics/usage/rules.md Show resolved Hide resolved
_security-analytics/usage/rules.md Show resolved Hide resolved
<br><img src="{{site.url}}{{site.baseurl}}/images/Security/rule-dup2.png" alt="Opening the rule details pane" width="500">
1. Select the **Duplicate** button in the upper-right corner of the pane. The Duplicate rule window opens in Visual Editor view and all of the fields are automatically populated with the rule's details. Details are also populated in YAML Editor view.
<br><img src="{{site.url}}{{site.baseurl}}/images/Security/dupe-rule.png" alt="Selecting the duplicate button opens the Duplicate rule window" width="500">
1. In either Visual Editor view or YAML Editor view, modify any of the fields to customize the rule.
1. After performing any modifications to the rule, select the **Create** button in the lower-right corner of the window. A new and customized rule is created, and it appears in the list of rules on the main page of the Rules window.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace double space between "A" and "new" with single space.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Signed-off-by: cwillum <cwmmoore@amazon.com>
@cwillum cwillum merged commit e641a3b into main Jan 14, 2023
@cwillum cwillum removed the 4 - Doc review PR: Doc review in progress label Jan 23, 2023
vagimeli pushed a commit that referenced this pull request Jan 25, 2023
* fix#2400-yaml-editor-rules

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#2400-yaml-editor-rules

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#2400-yaml-editor-rules

Signed-off-by: cwillum <cwmmoore@amazon.com>

Signed-off-by: cwillum <cwmmoore@amazon.com>
vagimeli added a commit that referenced this pull request Jan 26, 2023
@hdhalter hdhalter deleted the fix#2400-edit-YAML-view branch March 28, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes PR: Include this PR in the automated release notes v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants